← Back to issue list

unpack chisel slices

View original Github issue

Metadata

Project
craft-parts
Number
#281
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged implementation to unpack chisel slices via PullState routing from pull to build step. Updated CI Go version, added integration tests, and verified locally. Approved by two reviewers, +365/-66 lines across 8 files.

Suggested action:

No scores available.

Issue body

This is done by using the `PullState` to "transmit" the list of slices from the pull step (that currently doesn't do anything for slices) to the build step (that does the actual cutting). The integration test needs the "chisel" binary, so it's set to run on CI only. This required updating the workflow to use a newer version of "go" to build chisel. I then needed to revert back to the default Ubuntu 20.04 version because other tests need an older version (might be worth looking into). In addition to the tests I also built a local `rockcraft` snap using this code, and used it to build an image containing "sliced" files.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged implementation to unpack chisel slices via PullState routing from pull to build step. Updated CI Go version, added integration tests, and verified locally. Approved by two reviewers, +365/-66 lines across 8 files.
qwen3.6-35b-a3b-mtp-q6 Merged implementation to unpack chisel slices by routing slice data from the pull step to the build step via PullState. Updated CI workflow to adjust Go and Ubuntu versions for integration tests. Verified locally with rockcraft.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1715 refactor: put chisel call in its own module craft-parts merged Merged refactoring that extracts the chisel call into a dedicated module, decoupling slice cutting from path normalization to support upcoming build-slices changes. Approved by two reviewers.
73%
#625 ci: update chisel (#622) craft-parts merged Merged a cherry-pick PR to update the chisel dependency and fix CI in a feature branch. Approved by two reviewers with passing checks, the change modified one file (+3/-1 lines) to resolve continuous integration failures.
72%
#4441 feat: enable chisel snapcraft merged Merged into main after passing CI and receiving approval from two reviewers. The change enables chisel, adding 45 lines across three files with no test coverage impact.
72%
#294 Release 1.15.0 craft-parts merged Merged release 1.15.0 following approval and successful CI checks. The update implements chisel slices support and adds a go-generate property to the Go plugin, affecting five files with minimal code changes.
71%
#592 fix(deb): normalize chisel slices craft-parts merged Merged. Normalizes chisel slices during deb unpacking to fix absolute symlinks and prevent external path references. Resolves #578. Approved by two reviewers and passed CI.
71%
#279 spec: add "stage-slices" for chisel slices craft-parts merged Merged the addition of a stage-slices specification to handle chisel slice naming conventions, which require underscores unlike standard .deb packages. Approved by one reviewer, modified two files, and resolved CRAFT-1329.
71%
#590 fix(deb): normalize chisel slices craft-parts closed Merged fix normalizing chisel slices during deb unpacking to correct absolute symlinks, resolving issue #578. Approved by two reviewers with passing CI checks.
71%
#84 Add chisel to rockcraft rockcraft merged Merged after approval and passing CI. Integrated chisel into rockcraft to support chisel slices in stage-packages. Temporarily pinned craft-parts to a main branch commit pending an official release. Added a spread test for the dotnet-runtime-6.0_libs slice.
71%
#271 Split chisel explanation rockcraft merged Merged after two reviewers approved. The PR splits the chisel explanation and clarifies documentation descriptions and images. A minor CI output discussion was resolved without blocking changes, and the documentation updates were successfully integrated.
71%