chore(linter): refine ruff configurations
Metadata
Current evaluation
Merged PR #651 (commit 658dde3c) re-added previously removed Pylint (PLR) rules to the Ruff lint config in pyproject.toml, now present as [tool.ruff.lint.pylint] and per-file ignores.
Resolution: closed resolved
Reason: The PR was approved and merged into main as commit 658dde3c 'chore(linter): refine ruff configurations (#651)'. Its effect is visible in pyproject.toml, which now sets [tool.ruff.lint.pylint] max-args = 8 and lists PLR0913/PLR0917/PLR2004 test per-file ignores, with PLR noqa markers across craft_parts sources.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
This pull request adds the previously removed Pylint rules back to Ruff (since Ruff recently added support for them).
The commented-out rule is currently a work in progress upstream: https://github.com/astral-sh/ruff/pull/9844.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #651 (commit 658dde3c) re-added previously removed Pylint (PLR) rules to the Ruff lint config in pyproject.toml, now present as [tool.ruff.lint.pylint] and per-file ignores. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into main in commit 658dde3c via PR #651, restoring removed Pylint rules in Ruff; one rule remains commented pending upstream support. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into main after passing CI and receiving two approvals. The change restores previously removed Pylint rules to the Ruff linter configuration, with one rule temporarily commented out pending upstream updates. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after rebasing against main. The change re-adds previously removed Pylint rules to Ruff now that they are supported. One rule remains commented pending upstream resolution. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #965 chore(lint): enable passing Ruff rules | craft-providers | closed | PR #965 (enabling Ruff rules D215, A003, PLW1641) was closed unmerged: @bepri rejected it because the ignores are intentional for uniformity across Canonical repos. Rules remain in pyproject.toml ignore list. | |
| #36 chore: switch to ruff | craft-platforms | merged | Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files. | |
| #317 chore: update ruff configuration for 0.8 | craft-cli | merged | Merged PR #317 as commit b64b36c, removing two unsupported Ruff rule references from pyproject.toml to align the configuration with Ruff 0.8. | |
| #700 chore: update ruff | craft-parts | merged | Merged PR #700 updated Ruff configuration across four files, superseding #699; a follow-up lint issue was fixed in merged PR #702. | |
| #564 chore(deps): update dependency lint/ruff to v0.4.2 | craft-providers | merged | Renovate PR merged: bumped lint/ruff pin from 0.3.7 to 0.4.2 in pyproject.toml (single-line change, approved, no CI issues). Superseded shortly after by #566 (ruff 0.4.3). | |
| #165 chore(deps): update dependency lint/ruff to v0.1.7 | craft-application | merged | Renovate PR #165 bumped lint/ruff from 0.1.6 to 0.1.7 in pyproject.toml (+1/-1). Approved by 2 reviewers and merged into main as commit 8d5b9926. | |
| #562 Remove pylint in favour of ruff | craft-parts | closed | Pylint was dropped in favour of ruff by merged PR #580 (commit 111c8907, "chore(linter): enable ruff base on starbase config"), removing the [tool.pylint] config and CI/Makefile/dependency usage; ruff config expanded to cover it. | |
| #360 chore: remove now-deprecated linter rule | starbase | merged | Merged as commit 013b8e5, removing deprecated Ruff ANN10* configuration and resolving TOML validator complaints. | |
| #155 chore(deps): update dependency lint/ruff to v0.1.15 | craft-store | merged | Renovate PR merged as commit dbb47aa, bumping lint/ruff in pyproject.toml from ==0.1.9 to ==0.1.15 (+1/-1 line). Approved with no CI failures. | |
| #181 chore(deps): update dependency lint/ruff to v0.1.14 | craft-application | merged | Renovate PR bumping lint/ruff from ==0.1.11 to ==0.1.14 was approved by 3 reviewers and merged into main (commit bf491e38), a one-line pyproject.toml change; CI and Codecov checks were clean. |