← Back to issue list

chore(linter): refine ruff configurations

View original Github issue

Metadata

Project
craft-parts
Number
#651
Type
pull request
State
merged
Author
liushuyu
Labels
Created
Updated
Closed

Current evaluation

Merged into main after passing CI and receiving two approvals. The change restores previously removed Pylint rules to the Ruff linter configuration, with one rule temporarily commented out pending upstream updates.

Suggested action:

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- This pull request adds the previously removed Pylint rules back to Ruff (since Ruff recently added support for them). The commented-out rule is currently a work in progress upstream: https://github.com/astral-sh/ruff/pull/9844.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into main after passing CI and receiving two approvals. The change restores previously removed Pylint rules to the Ruff linter configuration, with one rule temporarily commented out pending upstream updates.
qwen3.6-35b-a3b-mtp-q6 Merged after rebasing against main. The change re-adds previously removed Pylint rules to Ruff now that they are supported. One rule remains commented pending upstream resolution.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#22 chore(lint): update ruff and config starbase merged Merged ruff linter and configuration updates. Added an ignore rule for test functions with excessive arguments. Approved by one reviewer, modifying two files with a +4/-2 line change.
83%
#580 chore(linter): enable ruff base on starbase config craft-parts merged Merged a chore enabling the ruff linter based on the starbase configuration. Approved by two reviewers, the update modified six files with 224 additions and 134 deletions.
82%
#715 chore(lint): use ruff from snap craft-parts merged Merged a linting chore switching to ruff from snap. Approved by two reviewers, the change modifies three files with a net reduction of two lines.
82%
#700 chore: update ruff craft-parts merged Merged after approval by two reviewers and passing CI checks. Updates ruff configuration across four files, supersedes #699, and resolves a lint issue addressed in #702.
81%
#965 chore(lint): enable passing Ruff rules craft-providers closed Rejected. The proposal to enable specific Ruff lint rules was declined because they are intentionally ignored to maintain uniformity across repositories, not due to current code violations.
81%
#543 chore(lint): remove isort rockcraft merged Merged a pull request replacing isort with Ruff for linting. The update modifies three files to utilize Ruff's capabilities, streamlining the configuration. Approved by two reviewers.
81%
#1347 chore(deps): update ruff and fix new linting errors charmcraft merged Merged after updating the ruff dependency and fixing new linting errors. Modifications were largely autoformatted across ten files. The changes received dual reviewer approval, passed CI checks, and were successfully integrated.
80%
#200 chore(deps): update ruff and its configuration craft-application merged Merged an update to ruff and its configuration. Approved by two reviewers with passing CI checks. The change modified one file with five additions and five deletions.
79%
#146 chore(deps): include ruff in dev updates starbase merged Merged into main after approval and passing CI. The update incorporates the ruff linter into development dependencies following its 0.1 release, changing one file with no effect on test coverage.
79%
#103 chore: fix new lints from ruff 0.12 craft-grammar merged Merged after approval and passing CI checks. Updated pre-commit ruff to 0.12 and resolved newly introduced lint errors across four files. Changes were cherry-picked from canonical/starbase#409.
78%