← Back to issue list

chore: remove now-deprecated linter rule

View original Github issue

Metadata

Project
starbase
Number
#360
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 013b8e5, removing deprecated Ruff ANN10* configuration and resolving TOML validator complaints.

Resolution: closed resolved

Reason: PR canonical/starbase#360 was approved and merged as commit 013b8e5, deleting the obsolete Ruff linter rule configuration from pyproject.toml.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- ANN10* ruff rules have been deprecated and removed since they were so commonly ignored. This PR removes it to fix TOML validators complaining.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 013b8e5, removing deprecated Ruff ANN10* configuration and resolving TOML validator complaints.
stealth/space-bunny-alpha — closed resolved Merged canonical/starbase#360, removing the deprecated Ruff ANN10* rule configuration to resolve TOML validator errors.
qwen/qwen3.6-35b-a3b — — Merged removal of deprecated ANN10* ruff linter rules to resolve TOML validator errors. Approved by reviewers, passed CI, and deleted one config line.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of deprecated ANN10* ruff linter rules to fix TOML validator errors. The change passed lint and test checks and was integrated by a maintainer.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#651 chore(linter): refine ruff configurations craft-parts merged Merged PR #651 (commit 658dde3c) re-added previously removed Pylint (PLR) rules to the Ruff lint config in pyproject.toml, now present as [tool.ruff.lint.pylint] and per-file ignores.
77%
#965 chore(lint): enable passing Ruff rules craft-providers closed PR #965 (enabling Ruff rules D215, A003, PLW1641) was closed unmerged: @bepri rejected it because the ignores are intentional for uniformity across Canonical repos. Rules remain in pyproject.toml ignore list.
76%
#22 chore(lint): update ruff and config starbase merged Merged in canonical/starbase#22 via commit f3d35a6, updating Ruff and its config to ignore excessive test-function arguments (PLR0913).
75%
#317 chore: update ruff configuration for 0.8 craft-cli merged Merged PR #317 as commit b64b36c, removing two unsupported Ruff rule references from pyproject.toml to align the configuration with Ruff 0.8.
75%
#36 chore: switch to ruff craft-platforms merged Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files.
74%
#2442 chore: fix ruff warnings from test files charmcraft merged PR #2442 merged (commit 8d54de9c): replaced deprecated Ruff-flagged constructs in five test files, clearing lint deprecation warnings. Only snap-store-tests failed, unrelated to the change.
72%
#5194 chore: fix small pyproject.yaml errors snapcraft merged Merged PR #5194 (commit 6a2b36b89) cleaned pyproject.toml: dropped deprecated Ruff rules ANN101/ANN102 and fixed an invalid Black config variable.
72%
#131 chore(deps): update dependency lint/ruff to v0.0.291 starbase merged Renovate dependency bump of lint/ruff from v0.0.290 to v0.0.291 in .pre-commit-config.yaml was approved and merged into main as commit c3c3313.
72%
#230 chore(deps): update dependency lint/ruff to v0.1.15 craft-cli merged Renovate PR merged (commit e68b0c7), bumping the ruff lint hook from 0.1.14 to 0.1.15 in .pre-commit-config.yaml; approved by two reviewers with no CI failures.
72%
#172 chore(deps): update dependency lint/ruff to v0.1.11 craft-application merged Renovate dependency bump merged as commit a2ab6c42, raising the lint group's ruff pin from 0.1.7 to 0.1.11 (single-line pyproject.toml change); later superseded by #181/#190.
72%