chore(lint): enable passing Ruff rules
Metadata
Current evaluation
PR #965 (enabling Ruff rules D215, A003, PLW1641) was closed unmerged: @bepri rejected it because the ignores are intentional for uniformity across Canonical repos. Rules remain in pyproject.toml ignore list.
Resolution: closed not a bug
Reason: Closed unmerged by maintainer @bepri with the comment that these rules are intentionally ignored for uniformity across Canonical repositories, not because this repo violates them. D215/A003/PLW1641 are still present in pyproject.toml's ignore list, and tracking issue #325 was closed as stale.
Evaluated by: mr-cal-bot
No scores available.
Issue body
## Summary
Enable Ruff rules that already pass on the current codebase by removing them from the global ignore list:
- `D215`
- `A003`
- `PLW1641`
This keeps the change small and reduces the number of disabled lint rules tracked by #325.
Refs #325.
## Tests
- `env -u VIRTUAL_ENV uv run --group lint --group types ruff check .`
- `env -u VIRTUAL_ENV uv run --group lint --group types ruff check --select D215,A003,PLW1641 .`
- `env -u VIRTUAL_ENV uv run --group lint --group types ruff format --check pyproject.toml`
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed not a bug | PR #965 (enabling Ruff rules D215, A003, PLW1641) was closed unmerged: @bepri rejected it because the ignores are intentional for uniformity across Canonical repos. Rules remain in pyproject.toml ignore list. | |
| stealth/space-bunny-alpha | — | closed not a bug | Rejected unmerged: craft-providers#965 proposed enabling Ruff rules D215, A003, and PLW1641, but maintainers require uniformity across Canonical repositories. | |
| qwen/qwen3.6-35b-a3b | — | — | Rejected. The proposal to enable specific Ruff lint rules was declined because they are intentionally ignored to maintain uniformity across repositories, not due to current code violations. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Rejected. The pull request was closed because the targeted Ruff rules are intentionally ignored to maintain uniformity across repositories, as explained in issue #325. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-providers#325
(confidence 95%)
Tracking issue 'Ignore less of ruff's warnings' referenced by the PR body; closed as stale after #965 was rejected.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #651 chore(linter): refine ruff configurations | craft-parts | merged | Merged PR #651 (commit 658dde3c) re-added previously removed Pylint (PLR) rules to the Ruff lint config in pyproject.toml, now present as [tool.ruff.lint.pylint] and per-file ignores. | |
| #317 chore: update ruff configuration for 0.8 | craft-cli | merged | Merged PR #317 as commit b64b36c, removing two unsupported Ruff rule references from pyproject.toml to align the configuration with Ruff 0.8. | |
| #575 chore(lint): silent false positive for PLC0206 | craft-application | closed | PR #575 (silencing Ruff PLC0206 false positives, bumping ruff in pre-commit) was not merged; the author closed it as duplicated by #580, which was merged as commit 97347705 fixing ruff 0.8 lint issues. | |
| #360 chore: remove now-deprecated linter rule | starbase | merged | Merged as commit 013b8e5, removing deprecated Ruff ANN10* configuration and resolving TOML validator complaints. | |
| #22 chore(lint): update ruff and config | starbase | merged | Merged in canonical/starbase#22 via commit f3d35a6, updating Ruff and its config to ignore excessive test-function arguments (PLR0913). | |
| #36 chore: switch to ruff | craft-platforms | merged | Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files. | |
| #700 chore: update ruff | craft-parts | merged | Merged PR #700 updated Ruff configuration across four files, superseding #699; a follow-up lint issue was fixed in merged PR #702. | |
| #165 chore(deps): update dependency lint/ruff to v0.1.7 | craft-application | merged | Renovate PR #165 bumped lint/ruff from 0.1.6 to 0.1.7 in pyproject.toml (+1/-1). Approved by 2 reviewers and merged into main as commit 8d5b9926. | |
| #181 chore(deps): update dependency lint/ruff to v0.1.14 | craft-application | merged | Renovate PR bumping lint/ruff from ==0.1.11 to ==0.1.14 was approved by 3 reviewers and merged into main (commit bf491e38), a one-line pyproject.toml change; CI and Codecov checks were clean. | |
| #155 chore(deps): update dependency lint/ruff to v0.1.15 | craft-store | merged | Renovate PR merged as commit dbb47aa, bumping lint/ruff in pyproject.toml from ==0.1.9 to ==0.1.15 (+1/-1 line). Approved with no CI failures. |