chore(lint): enable passing Ruff rules
Metadata
Current evaluation
Rejected. The proposal to enable specific Ruff lint rules was declined because they are intentionally ignored to maintain uniformity across repositories, not due to current code violations.
Suggested action: —
No scores available.
Issue body
## Summary
Enable Ruff rules that already pass on the current codebase by removing them from the global ignore list:
- `D215`
- `A003`
- `PLW1641`
This keeps the change small and reduces the number of disabled lint rules tracked by #325.
Refs #325.
## Tests
- `env -u VIRTUAL_ENV uv run --group lint --group types ruff check .`
- `env -u VIRTUAL_ENV uv run --group lint --group types ruff check --select D215,A003,PLW1641 .`
- `env -u VIRTUAL_ENV uv run --group lint --group types ruff format --check pyproject.toml`
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Rejected. The proposal to enable specific Ruff lint rules was declined because they are intentionally ignored to maintain uniformity across repositories, not due to current code violations. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Rejected. The pull request was closed because the targeted Ruff rules are intentionally ignored to maintain uniformity across repositories, as explained in issue #325. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #651 chore(linter): refine ruff configurations | craft-parts | merged | Merged into main after passing CI and receiving two approvals. The change restores previously removed Pylint rules to the Ruff linter configuration, with one rule temporarily commented out pending upstream updates. | |
| #715 chore(lint): use ruff from snap | craft-parts | merged | Merged a linting chore switching to ruff from snap. Approved by two reviewers, the change modifies three files with a net reduction of two lines. | |
| #543 chore(lint): remove isort | rockcraft | merged | Merged a pull request replacing isort with Ruff for linting. The update modifies three files to utilize Ruff's capabilities, streamlining the configuration. Approved by two reviewers. | |
| #580 chore(linter): enable ruff base on starbase config | craft-parts | merged | Merged a chore enabling the ruff linter based on the starbase configuration. Approved by two reviewers, the update modified six files with 224 additions and 134 deletions. | |
| #22 chore(lint): update ruff and config | starbase | merged | Merged ruff linter and configuration updates. Added an ignore rule for test functions with excessive arguments. Approved by one reviewer, modifying two files with a +4/-2 line change. | |
| #575 chore(lint): silent false positive for PLC0206 | craft-application | closed | Aims to silence a false positive Ruff lint error and update pre-commit. The request was closed and duplicated by PR #580, which implemented the same changes. | |
| #123 chore(deps): update dependency lint/ruff to v0.0.285 | starbase | merged | Merged an automated dependency update for lint/ruff from v0.0.284 to v0.0.285. The change includes release notes detailing new rules, bug fixes, and performance improvements. Successfully merged after passing CI checks and receiving approval. | |
| #246 chore(deps): update dependency lint/ruff to ~=0.3.5 | craft-cli | merged | Merged automated dependency update for lint/ruff from 0.2.1 to 0.3.5. Approved by reviewers, passed CI checks, and applied a single-line configuration change. | |
| #103 chore: fix new lints from ruff 0.12 | craft-grammar | merged | Merged after approval and passing CI checks. Updated pre-commit ruff to 0.12 and resolved newly introduced lint errors across four files. Changes were cherry-picked from canonical/starbase#409. | |
| #700 chore: update ruff | craft-parts | merged | Merged after approval by two reviewers and passing CI checks. Updates ruff configuration across four files, supersedes #699, and resolves a lint issue addressed in #702. |