← Back to issue list

feat: reconcile overlays and partition features

View original Github issue

Metadata

Project
craft-parts
Number
#1035
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1035 at commit b575539e, enabling overlay and partition features simultaneously and fixing canonical/craft-parts#1028.

Resolution: closed resolved

Reason: PR #1035 was merged as commit b575539e. Its merged description explicitly states that it fixes #1028 by allowing overlays and partitions to be used together.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Allow usage of the overlay and partitions features simultaneously. Fixes #1028 Co-authored-by: Paul Mars <paul.mars@canonical.com> Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1035 at commit b575539e, enabling overlay and partition features simultaneously and fixing canonical/craft-parts#1028.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#1035 (b575539e), enabling overlay and partition features to be used simultaneously and fixing #1028.
qwen/qwen3.6-35b-a3b — — Merged. Implements simultaneous overlay and partition feature support, resolving issue #1028. Approved by three reviewers with passing CI. Further tests and refactoring will follow in a subsequent PR.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Resolves #1028 by enabling simultaneous overlay and partition feature usage. Follow-up tests and refactoring are planned.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#1028 (confidence 100%)

    The issue requesting simultaneous use of partition and overlay features was fixed by this PR.

Related issues

Issue Project State Summary Similarity
#667 fix: make overlay and partition features mutually exclusive craft-parts merged Merged PR #667 as commit 6582b829, making overlay and partitions mutually exclusive and fixing #632.
82%
#632 Make partitions and overlay features mutually exclusive craft-parts closed Resolved by merged PR #667 (commit 6582b829), which makes partition and overlay features mutually exclusive and rejects configurations enabling both.
80%
#1028 Allow enabling both partitions and overlays features at the same time craft-parts closed Enabled partitions and overlays to be used together in merged PR #1035 (commit b575539e), resolving the feature conflict.
80%
#1110 feat: cleaning with partitions craft-parts merged Merged PR #1110 adds partition-aware cleanup of shared areas for CRAFT-4585, following prerequisite #1109; it is recorded on main as commit 0584c19c.
76%
#1127 Failing to prime content with overlay and partitions craft-parts closed Fixed by merged PR canonical/craft-parts#1123 (commit 3540e306), using partition stage files and migration state when priming overlay content.
74%
#299 feat: enable override-overlay imagecraft merged Merged in #299 via commit 6d283be, upgrading craft-parts to ~=2.30 and adding spread coverage for override-overlay support.
73%
#1254 feat: allow parts to organize to overlay craft-parts merged PR #1254 was merged, adding the (overlay) organize target to move part build files to the top of the mounted overlay stack (commit 0c806f20).
73%
#367 features: introduce craft-parts features craft-parts merged Merged PR #367 via commit 16a81f95, introducing configurable craft-parts features and an overlay toggle that suppresses overlay action generation when disabled.
72%
#98 Enable overlay feature imagecraft closed Overlay support was implemented in imagecraft PR #110 (commit 00f1348), after craft-parts PR #1035 (b575539e) removed the partition/overlay blocker.
72%
#763 partitions feature documentation craft-parts merged Merged developer-facing partitions documentation in commit cdcc9dbc, completing CRAFT-3030 after approval by two reviewers.
72%