refactor: redesign partition validators
Metadata
Current evaluation
Partition-validator redesign landed in merged PR #668 via commit 85b9ba7a, consolidating duplicate validation and enabling checks during part initialization.
Resolution: closed resolved
Reason: The maintainer confirmed the changes were merged indirectly through PR #668. That PR merged as commit 85b9ba7a, so the redesign reached main despite #669 not being merged separately.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
There were two separate instances of validating partitions in two places. Both were run when intializing the LifecycleManager.
Since then, partitions are now passed to the part during initialization. This allows us to validate earlier when the part is initialized.
I have combined the best aspects of both validators.
This is a prerequisite to resolve #650 where I will need to add extra validation when the part is created.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Partition-validator redesign landed in merged PR #668 via commit 85b9ba7a, consolidating duplicate validation and enabling checks during part initialization. | |
| stealth/space-bunny-alpha | — | closed superseded | Partition-validator refactor was not merged on its own; the maintainer closed it after the changes landed as part of #668 (commit 85b9ba7a, 'fix: stage and prime content in all partitions by default'), which also fixed #650. | |
| stealth/space-bunny-alpha | — | closed superseded | Partition-validator redesign was merged indirectly through #668, consolidating validation and enabling earlier checks during part initialization. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged indirectly via #668. Consolidated duplicate partition validators into a single implementation that executes during part initialization, enabling earlier validation as a prerequisite for #650. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged indirectly via #668. Consolidated two separate partition validators into a single implementation that runs during part initialization, enabling earlier validation as a prerequisite for issue #650. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-parts#668
(confidence 100%)
Merged PR that included the validator redesign; also fixed prerequisite issue #650.
-
Related To:
craft-parts#650
(confidence 95%)
The redesign was described as a prerequisite for adding the validation needed to fix this issue.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #489 partitions: add feature and validation | craft-parts | merged | Merged as commit d363fa7c, adding the opt-in partitions feature to LifecycleManager/Dirs, partition name validation with new partition errors, and integration tests for CRAFT-1843. Follow-up PRs #493, #497 and #517 extended it. | |
| #599 feat(partitions): validate namespaced partitions | craft-parts | merged | Merged PR #599 as commit 06a5f999, adding namespaced partition validation during LifecycleManager initialization and fixing #595 (CRAFT-2032). |