fix: stage and prime content in all partitions by default
Metadata
Current evaluation
Merged in #668 as 85b9ba7a: filesets now stage and prime across all partitions by default and reject ambiguous configurations, fixing #650.
Resolution: closed resolved
Reason: PR #668 was merged as commit 85b9ba7a, implementing all-partition staging and priming by default with stricter validation. Its prerequisite partition-validator work from #669 was also incorporated.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
@cmatsuoka and I have found a much better solution. Instead of changing the default values of stage and prime keywords, we changed the behavior of the fileset that consumes the stage and prime keywords.
Depends on #669
Fixes #650
(CRAFT-2458)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in #668 as 85b9ba7a: filesets now stage and prime across all partitions by default and reject ambiguous configurations, fixing #650. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as 85b9ba7a (#668): filesets now stage and prime content in all partitions by default, reject ambiguous configurations, and fix #650. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after resolving issue #650 by modifying the fileset parser to stage and prime content across all partitions by default, instead of altering keyword defaults. Ambiguous partition configurations are now rejected. Merged following dependency #669. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix altering the fileset consumer to stage and prime content in all partitions by default, resolving #650. Ambiguous stage and prime configurations are now rejected. Landed after dependency #669 received final review. |
Update history
No update history recorded yet.
Related work
-
Related To:
craft-parts#650
(confidence 100%)
The original issue was fixed by merged PR #668.
-
Related To:
craft-parts#669
(confidence 95%)
Prerequisite partition-validator redesign incorporated through #668.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #664 fix: stage and prime content in all partitions by default | craft-parts | closed | Closed unmerged in favor of an alternative; PR #668 implemented default all-partition staging and priming and merged as commit 85b9ba7a. | |
| #663 fix: stage and prime content in all partitions by default | craft-parts | closed | PR #663 (fix: stage and prime content in all partitions by default) was closed unmerged in favour of #664; the final fix landed via merged PR #668, commit 85b9ba7a, implementing it in the fileset parser instead of PartSpec validators. | |
| #1123 fix: Prime content from overlay when split into partitions | craft-parts | merged | Merged PR #1123 (commit 3540e306), fixing overlay priming with partitions by using stage content and migration state while preserving existing prime state files. | |
| #834 fix: use partitions for stage-packages tracking | craft-parts | merged | Merged PR #834 as 4cbc6006, making stage-package tracking search primed files across partitions and fixing #804 for common cases; duplicate files across partitions remain unsupported. | |
| #650 Include all partitions by default for `stage` and `prime` keywords | craft-parts | closed | Fixed by merged PR #668 (commit 85b9ba7a): stage and prime now include all partitions by default while retaining per-partition filters. | |
| #607 fix(partitions): use base prime dir for getting primed stage packages | craft-parts | closed | Closed unmerged and superseded by the namespaced-partition work merged in #627 via commit 9fe38d11. |