← Back to issue list

feat(partitions): custom error for nonexistent partition

View original Github issue

Metadata

Project
craft-parts
Number
#826
Type
pull request
State
merged
Author
mattculler
Labels
Created
Updated
Closed

Current evaluation

Merged a feature introducing a custom error for nonexistent partitions to improve error handling in corncraft. Approved by three reviewers, passed CI, and modified three files. Temporary linter failures from cmake.org downtime were resolved prior to merge.

Suggested action:

No scores available.

Issue body

- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Raise a custom error when a nonexistent partition is asked for, so `corncraft` can catch it more cleanly. Depending on the stringification is fragile, but if you don't do some sort of deeper check then you could accidentally handle other `ValueError`s. (CRAFT-3031)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a feature introducing a custom error for nonexistent partitions to improve error handling in corncraft. Approved by three reviewers, passed CI, and modified three files. Temporary linter failures from cmake.org downtime were resolved prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged a feature adding a custom error for nonexistent partitions to improve error handling in corncraft. Initial lint failures from an external outage were resolved. Closes CRAFT-3031.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#493 partitions: validate usage of partitions in parts craft-parts merged Implemented partition validation for filepaths in the organize, overlay, stage, and prime keywords within parts. Merged after reviewer approval and passing CI checks, modifying seven files to resolve CRAFT-1844.
75%
#600 feat(partitions): handle namespaced partitions in utils craft-parts merged Merged following two reviewer approvals and passing CI. Updates utility functions to handle namespaced partitions across eight files (+229/-72 lines). Resolves #596 and CRAFT-2303.
74%
#652 feat(partitions): clean partition directories craft-parts merged Merged changes cleaning partition directories when the partitions feature is enabled. Approved by two reviewers, passed CI, and resolves issue #634.
74%
#801 fix: partitions break when using special characters craft-parts merged Merged fix for CRAFT-3031 resolving lifecycle failures from misinterpreted paths in partitions with numbers and hyphens. Approved by two reviewers, the change updates four files to correctly handle special characters.
73%
#673 feat(test): create partitioncraft craft-application merged Merged after dual approval, introducing partitioncraft to testcraft with basic lifecycle spread tests. One reviewer noted tests should be fixed before merge, but the changes were ultimately merged.
70%
#763 partitions feature documentation craft-parts merged Merged documentation for the partitions feature targeting application developers. Approved by two reviewers, the update adds 66 lines and removes 5 across nine files, resolving CRAFT-3030.
70%