DO NOT MERGE: tests: add some questionable but valid platform names
Metadata
Current evaluation
Discussion-only PR (title says DO NOT MERGE) by lengau adding 28 lines of 'questionable but valid' platform-name test data to spark discussion on platform-name limits. Never merged, no comments, pending review; validation was later shipped in #209.
Suggested action: close superseded
Reason: The author explicitly titled it 'DO NOT MERGE' and the body says it exists only 'for discussion about what, if any, limits we want to provide for platform names' — a 28-line, test-data-only diff with no CI results and pending review after 549 days. The underlying questions were resolved elsewhere: merged PR #209 ('feat: validate platform names') added validators.validate_strict_platform_name and tests/unit/test_validators.py (whose SAMPLE_VALID_PLATFORM_NAMES already contains entries like 'a-dead-badger' and '🇧🇷'), and #176 made 'any'/'*' invalid while #194 allowed colons without a base prefix. Nothing is left for this branch to deliver.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha |
Impact:
5
Quick Win:
0
Complexity:
5
Confidence:
82
Actionability:
10
|
close superseded | Discussion-only PR (title says DO NOT MERGE) by lengau adding 28 lines of 'questionable but valid' platform-name test data to spark discussion on platform-name limits. Never merged, no comments, pending review; validation was later shipped in #209. | |
| stealth/space-bunny-alpha |
Impact:
5
Quick Win:
1
Complexity:
10
Confidence:
75
Actionability:
15
|
close stale | Maintainer-authored, test-only PR (+28 lines, 1 file) explicitly titled 'DO NOT MERGE', opened to spark discussion on platform-name limits; never reviewed, 2 unresolved comments, no CI run, untouched for 547 days. | |
| stealth/space-bunny-alpha |
Impact:
20
Quick Win:
3
Complexity:
16
Confidence:
92
Actionability:
15
|
keep open | Adds 28 lines of tests for debatable but valid platform names, explicitly left unmerged for maintainer discussion; no reviews or CI after 541 days. | |
| stealth/space-bunny-alpha |
Impact:
15
Quick Win:
2
Complexity:
20
Confidence:
95
Actionability:
15
|
keep open | Adds test cases for unusual but valid platform names to discuss validation limits. Explicitly marked DO NOT MERGE; inactive for 541 days with two unresolved comments and zero reviewers. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
5
Quick Win:
4
Staleness:
95
Complexity:
10
Confidence:
85
|
close stale | Discussion PR about platform name validation limits, marked DO NOT MERGE. No activity for 521 days. Platform name validation already implemented in project. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
95
Complexity:
10
Confidence:
90
|
close stale | Adds test cases for questionable but valid platform names to explore naming limits. Currently inactive for over a year, awaiting maintainer discussion, with 0 reviewers and no CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
95
Complexity:
5
Confidence:
85
|
close stale | Test-only PR proposing questionable platform names to discuss validation limits. Inactive for over a year with no maintainer feedback or discussion. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/craft-platforms#209
(confidence 82%)
Merged PR implementing platform-name validation (validators.validate_strict_platform_name) plus the test file that now contains the 'questionable but valid' sample names.
-
Related To:
canonical/craft-platforms#176
(confidence 70%)
Made 'any' and '*' invalid platform names — a concrete answer to the name-limits question this PR was meant to discuss.
-
Related To:
canonical/craft-platforms#194
(confidence 65%)
Allows colons in platform names without a base prefix, settling part of the same naming-rules discussion.
-
Related To:
canonical/craft-application#1011
(confidence 55%)
Downstream consumer adding conditional strict platform-name validation on top of craft-platforms.
Related issues
No related issues found above the similarity threshold.