← Back to issue list

Possibly misleading error message when getting rock build plan

View original Github issue

Metadata

Project
craft-platforms
Number
#68
Type
issue
State
closed
Author
SuperAlpaca27
Labels
—
Created
Updated
Closed

Current evaluation

Bare Rock bases now receive targeted validation instead of a misleading distribution-format error. Fixed by merged PR canonical/craft-platforms#123 (80ac005).

Resolution: closed resolved

Reason: Merged PR canonical/craft-platforms#123 added validation for bare Rock bases in commit 80ac005. The maintainer explicitly marked #68 as fixed by that PR.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Running the following ```python from craft_platforms.rock import get_rock_build_plan base = "bare" build_base = None print(get_rock_build_plan(base=base, platforms={"amd64": None}, build_base=build_base)) ``` yields `ValueError: Invalid base string 'bare'. Format should be '<distribution>@<series>'` It should probably say something like "build-base required for 'bare' base" or similar. craft-platforms version is `0.3.0` here

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Bare Rock bases now receive targeted validation instead of a misleading distribution-format error. Fixed by merged PR canonical/craft-platforms#123 (80ac005).
stealth/space-bunny-alpha — closed resolved Fixed in merged PR #123; v0.7.1 now reports an explicit error when a bare base is used without a build-base.
qwen/qwen3.6-35b-a3b — — Fixed misleading ValueError when calling get_rock_build_plan with a bare base and missing build_base. The error message now correctly indicates that build_base is required. Resolved via merged pull request #123.
qwen/qwen3.6-35b-a3b — — Fixed a misleading error message when calling get_rock_build_plan with a bare base and missing build-base. The update now clearly states that a build-base is required. Resolved and merged via pull request #123.
qwen3.6-35b-a3b-mtp-q6 — — Fixed misleading ValueError for missing build_base in get_rock_build_plan. The improved error message was merged in canonical/craft-platforms pull request 123.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-platforms#123 (confidence 100%)

    Merged fix for validating bare Rock bases; maintainer cited it as the resolution.

Related issues

Issue Project State Summary Similarity
#123 fix: validate bare bases for rockcraft craft-platforms merged Merged PR #123 (commit 80ac005) added bare-base validation for rocks: get_rock_build_plan now raises NeedsBuildBaseError when base is "bare" with no build-base. Shipped in 0.7.1.
74%
#633 fix: improve `platforms.<platform>.build-on` validation rockcraft closed Closed unmerged as redundant: PR canonical/rockcraft#567 had already improved build-on validation by adopting craft-application's default BuildPlanner.
72%
#698 Use craft-platforms for build plans rockcraft closed Merged PR #715 (516d29e5) replaced Rockcraft's custom build-plan generation with craft-platforms, resolving #698 and aligning plans with downstream consumers.
71%