← Back to issue list

Use craft-platforms for build plans

View original Github issue

Metadata

Project
rockcraft
Number
#698
Type
issue
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #715 (516d29e5) replaced Rockcraft's custom build-plan generation with craft-platforms, resolving #698 and aligning plans with downstream consumers.

Resolution: closed resolved

Reason: PR #715 was merged with commit 516d29e5, adopting craft-platforms for build planning and explicitly closing #698.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Use craft-platforms for creating build plans See prototype here: https://github.com/canonical/rockcraft/pull/662 ### Why it needs to get done * To deduplicate similar build planning logic * To ensure consistent build plans between rockcraft and consumers of craft-platforms, like Launchpad

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #715 (516d29e5) replaced Rockcraft's custom build-plan generation with craft-platforms, resolving #698 and aligning plans with downstream consumers.
stealth/space-bunny-alpha — closed resolved Resolved through canonical/rockcraft#715 (516d29e5), replacing Rockcraft-specific build planning with shared craft-platforms logic for consistent downstream build plans.
qwen/qwen3.6-35b-a3b — — Closed and superseded by prototype PR #662, which implements craft-platforms for build plans to deduplicate logic and ensure consistency across projects. No explicit resolution or merge details are documented.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The request to adopt craft-platforms for build plans was moved to internal Jira tracking (CRAFT-3323) and abandoned. No code changes or merges were applied.
qwen/qwen3.6-35b-a3b — — Closed without resolution. The craft-platforms integration for build plans was not implemented, with only an internal Jira ticket created for tracking.
qwen3.6-35b-a3b-mtp-q6 — — Closed without a documented resolution. The proposal to use craft-platforms for build plans was not implemented and appears abandoned or superseded by later work.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/rockcraft#715 (confidence 100%)

    Merged implementation that switched build-plan generation to craft-platforms.

  • Related To: canonical/rockcraft#662 (confidence 95%)

    Prototype cited in the issue for the craft-platforms build-planning work.

Related issues

Issue Project State Summary Similarity
#715 refactor: use craft-platform for the build plans rockcraft merged Merged PR #715 (516d29e5) replaced Rockcraft’s custom build-plan generation with craft-platform, creating one shared source for Rockcraft and remote builds; fixes #698.
89%
#1876 Use craft-platforms for build plans charmcraft closed Closed as done: charmcraft PR #1894 (commit f1755e8f) switched build plan generation to craft-platforms via craft-application's BuildPlanService; rockcraft did the same in #715.
87%
#5015 Use craft-platforms for build plans snapcraft closed Snapcraft adopted craft-platforms build plans in merged PR #5111 (commit 7969ee8d5), replacing its custom planning logic.
85%
#391 Use craft-platforms for build plans craft-application closed Build planning and filtering moved to craft-platforms in merged PR #25 (d9ff004); craft-application adopted the planner through merged PR #666 (621d1a32).
83%
#1894 refactor: use craft-platforms for build plans charmcraft merged Merged PR #1894 (commit f1755e8f, +25/-33) replaced Charmcraft's custom build-plan generation for `platforms` charms with craft-platforms, routing exhaustive build plans through craft-application's BuildPlanService.
81%
#639 Move the build planner logic into craft-platforms rockcraft closed Build planner logic extracted to craft-platforms in merged PR canonical/craft-platforms#25 (commit d9ff004); rockcraft later simplified in commit 5f898b32. Maintainer mr-cal confirmed completion.
81%
#5111 feat: use `craft-platforms` for build plans snapcraft merged Merged in #5111 via commit 7969ee8d5, replacing Snapcraft’s custom build-plan logic with craft-platforms utilities.
80%
#15 Implement a rock build planner craft-platforms closed Rock build planning was implemented and merged in canonical/craft-platforms#25 via commit d9ff004.
77%
#662 [PROTOTYPE] refactor: use craft-platforms rockcraft closed Prototype PR #662 was closed unmerged in August 2024; the production build-planner migration later landed via rockcraft#715 at commit 516d29e5.
76%
#633 fix: improve `platforms.<platform>.build-on` validation rockcraft closed Closed unmerged as redundant: PR canonical/rockcraft#567 had already improved build-on validation by adopting craft-application's default BuildPlanner.
75%