← Back to issue list

lint: enable pylint useless-supression, minor reformatting

View original Github issue

Metadata

Project
craft-providers
Number
#192
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged lint cleanup in craft-providers#192 via commit f644c25, enabling pylint's useless-suppression check, removing obsolete suppressions, and reformatting seven files without functional changes.

Resolution: closed resolved

Reason: PR #192 was merged into the project as commit f644c25. The merged change enabled pylint useless-suppression reporting and applied non-functional formatting cleanup.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- I made some linter changes that have been bothering me: - Remove useless pylint suppression with `useless-suppression` check. - Minor reformats to combat `black`'s habit to split lines All pedantic changes, nothing functional. For example, I prefer to change: ``` return subprocess.run( # pylint: disable=subprocess-run-check final_cmd, **kwargs ) ``` to ``` # pylint: disable-next=subprocess-run-check return subprocess.run(final_cmd, **kwargs) ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged lint cleanup in craft-providers#192 via commit f644c25, enabling pylint's useless-suppression check, removing obsolete suppressions, and reformatting seven files without functional changes.
qwen/qwen3.6-35b-a3b — closed resolved Merged lint changes enabling pylint useless-suppression check and applying minor black reformatting across 7 files. No functional changes.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#3813 lint: bump pylint snapcraft merged Merged in commit 522b301a9: updated Pylint and removed a redundant too-many-lines suppression across three files.
76%
#164 lint: compliance with pylint-2.12.2 (CRAFT-716) craft-parts merged Merged PR #164 as 53ee6b27, updating 41 files for pylint 2.12.2 compliance; its explicit file-I/O encoding changes were later reverted in 42d91e33.
75%
#216 lint: remove pylint useless suppression "too-many-lines" craft-providers merged Merged in a8d5fc5: removed the obsolete pylint too-many-lines suppression after the file fell below 1,000 LOC.
75%
#243 lint: remove 'module imported but unused' suppression craft-providers merged Merged in canonical/craft-providers#243 via commit ec2437c, removing unnecessary Flake8 F401 import suppressions across four files.
74%
#4817 style: remove pylint snapcraft merged Merged as a9badaa32, removing Pylint from lint tooling, configuration, and source suppressions after Ruff had replaced nearly all of it.
74%
#66 lint: update pylint configuration craft-store merged Merged PR #66 as commit 20c7aa9, refreshing the pylint configuration without functional code changes.
73%
#291 lint: remove leftover pylint directive craft-parts merged Merged PR #291 in commit fb583a60, removing one leftover pylint directive from a single file.
71%