← Back to issue list

style: remove pylint

View original Github issue

Metadata

Project
snapcraft
Number
#4817
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged as a9badaa32, removing Pylint from lint tooling, configuration, and source suppressions after Ruff had replaced nearly all of it.

Resolution: closed resolved

Reason: PR #4817 was merged with commit a9badaa32, completing the removal of Pylint now that Ruff provides equivalent linting.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Pylint is pretty much entirely replaced with ruff at this point. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as a9badaa32, removing Pylint from lint tooling, configuration, and source suppressions after Ruff had replaced nearly all of it.
stealth/space-bunny-alpha — closed resolved Merged as snapcraft#4817, removing pylint configuration now fully replaced by ruff.
qwen/qwen3.6-35b-a3b — — Merged removal of pylint configuration, fully replaced by ruff. Approved by three reviewers, passed CI checks, and modified 46 files across the codebase.
qwen3.6-35b-a3b-mtp-q6 — — Pylint removed and replaced with ruff for linting. The change passed all lint and test checks, then merged successfully by maintainer lengau.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#4848 (confidence 95%)

    Follow-up PR #4848, merged as f5e002565, removed remaining Pylint comments left after #4817.

Related issues

Issue Project State Summary Similarity
#118 style: remove pylint craft-store merged Merged PR #118 as commit beb9201, removing Pylint configuration and tooling after Ruff had replaced it.
90%
#562 Remove pylint in favour of ruff craft-parts closed Pylint was dropped in favour of ruff by merged PR #580 (commit 111c8907, "chore(linter): enable ruff base on starbase config"), removing the [tool.pylint] config and CI/Makefile/dependency usage; ruff config expanded to cover it.
80%
#675 style(lint): replace pylint with ruff rockcraft merged Merged as b7d70598, replacing pylint with Ruff, adding Ruff to CI and project requirements, and enabling equivalent lint coverage.
78%
#216 lint: remove pylint useless suppression "too-many-lines" craft-providers merged Merged in a8d5fc5: removed the obsolete pylint too-many-lines suppression after the file fell below 1,000 LOC.
75%
#291 lint: remove leftover pylint directive craft-parts merged Merged PR #291 in commit fb583a60, removing one leftover pylint directive from a single file.
74%
#3813 lint: bump pylint snapcraft merged Merged in commit 522b301a9: updated Pylint and removed a redundant too-many-lines suppression across three files.
74%
#192 lint: enable pylint useless-supression, minor reformatting craft-providers merged Merged lint cleanup in craft-providers#192 via commit f644c25, enabling pylint's useless-suppression check, removing obsolete suppressions, and reformatting seven files without functional changes.
74%
#4712 Move more linting to ruff snapcraft closed Ruff linting was completed and aligned with Starbase; pylint and isort were removed in #4817 and commit a00f1c439, followed by pylint cleanup in #4848.
73%
#66 lint: update pylint configuration craft-store merged Merged PR #66 as commit 20c7aa9, refreshing the pylint configuration without functional code changes.
73%
#288 lint: add ruff, remove autoflake, flake8, isort, pydocstyle, pylint craft-providers merged Merged PR #288 in commit 42a7920, replacing autoflake, flake8, isort, pydocstyle, and pylint with Ruff; deferred Ruff rule cleanup was tracked in #287.
72%