← Back to issue list

lxd: introduce LXC to interface with lxc

View original Github issue

Metadata

Project
craft-providers
Number
#31
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR adding the LXC wrapper class to craft_providers/lxd/lxc.py for all lxc CLI interaction (+2627/-0, 3 files). Merged as 38f233f (feature commit 0d400f6); integration tests landed separately in #32.

Resolution: closed resolved

Reason: PR #31 was approved by 2 reviewers and merged to main as commit 38f233f ("Merge pull request #31 from cjp256/lxc"), with squashed work beginning at 0d400f6 "lxd: introduce LXC to interface with lxc". The deferred integration tests were merged later in PR #32 (commit e392301).

Evaluated by: mr-cal-bot

No scores available.

Issue body

To keep the size of the PR down, integration test will follow as a separate PR, as it requires some additional helpers. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR adding the LXC wrapper class to craft_providers/lxd/lxc.py for all lxc CLI interaction (+2627/-0, 3 files). Merged as 38f233f (feature commit 0d400f6); integration tests landed separately in #32.
qwen/qwen3.6-35b-a3b — closed resolved Merged PR introducing LXC interface for lxc integration in lxd. Approved by 2 reviewers with passing CI checks.

Update history

Date Change
created

Related work

  • Related To: craft-providers#32 (confidence 90%)

    Follow-up PR by the same author adding lxc project helpers and the integration tests deliberately deferred out of #31.

  • Related To: craft-providers#51 (confidence 45%)

    Later feature work building on the LXC wrapper (has_image helper and yaml BaseLoader), showing the abstraction landed and is still in use.

Related issues

Issue Project State Summary Similarity
#34 lxd: introduce LXD for interacting with `lxd` command-line craft-providers merged Merged PR #34 (commit 2a9e742, merge e181ccd) added an LXD class wrapping the `lxd` CLI plus is_supported_version() for minimum-version checks; it ships in craft_providers/lxd/lxd.py today.
81%
#32 lxc: add project helpers and integration integration tests craft-providers merged Merged PR #32 added LXC project helpers and integration tests, landing as merge commit e392301 with implementation commit 9b72743.
78%
#42 feat(test-python): install lxd starflow merged Merged #42 as commit 2c6a4a5, adding opt-in LXD setup for test-python hosted runners so use-lxd works with craft-providers.
75%
#36 lxd: introduce installation support craft-providers merged Merged PR #36 added LXD installation support, including installer logic and tests; implementation commit aab8fd0 was merged via 1a1212c.
75%
#33 lxd: introduce LXDInstance craft-providers merged Merged as commit 260c038, introducing LXDInstance, exposing the lxc fixture to LXD integration tests, and adding unit and integration coverage.
74%
#207 tests: split lxd integration tests craft-providers merged Merged #207 to split LXD integration tests, resolving review feedback from #205; landed as commit 3eba5ca.
74%
#56 feat(test-python): optionally setup lxd starflow closed Merged PR #56 added optional LXD setup to test-python, enabling craft-providers testing; all CI checks passed.
73%
#57 lxd launcher: enable configuration of project & remote (CRAFT-304) craft-providers merged Merged PR #57 added configurable LXD project and remote support, with updated unit tests and new integration coverage; implemented in commit b420280.
72%
#3725 tests: use lxd in clean provider test snapcraft merged Merged PR #3725 (commit 61aaff6fc) into snapcraft/7.0, enabling LXD in provider-cleaning unit tests so they match destructive-mode test runs. Approved by one maintainer reviewer.
72%
#2509 build providers: initial support for LXD snapcraft merged Merged PR #2509 (commit 067024732) adding initial LXD build-provider support: `snapcraft --use-lxd` runs all lifecycle steps and clean inside an LXD container. Released via beta/lxd channel; LP bug #1805221 closed.
70%