← Back to issue list

tests: split lxd integration tests

View original Github issue

Metadata

Project
craft-providers
Number
#207
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #207 to split LXD integration tests, resolving review feedback from #205; landed as commit 3eba5ca.

Resolution: closed resolved

Reason: PR #207 was approved with no unresolved review comments and merged as commit 3eba5ca. It split the LXD integration tests in follow-up to feedback on #205.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Follow up from https://github.com/canonical/craft-providers/pull/205#discussion_r1092511264

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #207 to split LXD integration tests, resolving review feedback from #205; landed as commit 3eba5ca.
qwen/qwen3.6-35b-a3b — closed resolved Merged PR #207 that split LXD integration tests in craft-providers, following up on review feedback from PR #205.

Update history

Date Change
created

Related work

Related issues

Issue Project State Summary Similarity
#2983 tests: add LXD spread test snapcraft merged Merged PR #2983 as 4b8522a14, adding spread coverage that builds the LXD package with LXD and destructive/host providers; installation checks were deferred.
76%
#178 tests: refactor lxd launcher tests craft-providers merged Merged PR #178 in commit 43146e2 refactored LXD launcher tests to distinguish regular instances from base instances, enabling the test coverage needed by #177.
75%
#1820 Update test_lxd.py snapcraft closed PR #1820's test cleanup was closed unmerged after a reviewer noted it did not increase LXD test coverage; no resolving commit or replacement was identified.
74%
#31 lxd: introduce LXC to interface with lxc craft-providers merged Merged PR adding the LXC wrapper class to craft_providers/lxd/lxc.py for all lxc CLI interaction (+2627/-0, 3 files). Merged as 38f233f (feature commit 0d400f6); integration tests landed separately in #32.
74%
#44 integration tests: consolidate lxd/multipass fixtures for reuse craft-providers merged Merged PR #44 in commit ee0f643, consolidating reusable LXD and Multipass integration-test fixtures and including a documentation fix.
73%
#262 tests: install docker after lxd rockcraft merged Merged PR #262 as 64c5c01b, changing spread-test setup to install Docker after LXD and avoid order-dependent failures.
73%
#3725 tests: use lxd in clean provider test snapcraft merged Merged PR #3725 (commit 61aaff6fc) into snapcraft/7.0, enabling LXD in provider-cleaning unit tests so they match destructive-mode test runs. Approved by one maintainer reviewer.
73%
#467 test(spread): use LXD provider for spread tests imagecraft closed PR closed without merge; spread LXD provider changes were implemented across follow-up PRs (#483, #485, #486, #487, #488, #495)
73%
#32 lxc: add project helpers and integration integration tests craft-providers merged Merged PR #32 added LXC project helpers and integration tests, landing as merge commit e392301 with implementation commit 9b72743.
73%
#1807 tests: run test_cleanbuild in LXD on Travis snapcraft merged Merged PR #1807 (commit 70df69b9a) by kalikiana, making test_cleanbuild run in LXD on Travis so it is no longer skipped when tests run as a snap; fixes LP #1738210. Reviewer asked to revert the last commit keeping LXD for cleanbuild only.
72%