← Back to issue list

tests: use lxd in clean provider test

View original Github issue

Metadata

Project
snapcraft
Number
#3725
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged into snapcraft/7.0. Enables LXD in provider cleaning tests to align with destructive mode testing. Approved by one reviewer, passed CI checks, and maintained existing code coverage.

Suggested action: —

No scores available.

Issue body

Tests are ordinarily conducted in destructive mode, enable lxd in provider cleaning tests. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged into snapcraft/7.0. Enables LXD in provider cleaning tests to align with destructive mode testing. Approved by one reviewer, passed CI checks, and maintained existing code coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into snapcraft/7.0. Updated provider cleaning tests to use LXD instead of destructive mode. Codecov confirmed zero coverage impact. The change enables LXD for cleaner test execution.
qwen3.6-35b-a3b-mtp-q6 — — Merged into snapcraft/7.0. Updates provider cleaning tests to use LXD, aligning with destructive mode testing. Codecov confirms no coverage change.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2509 build providers: initial support for LXD snapcraft merged Merged initial LXD build provider support for snapcraft, enabling the --use-lxd flag for lifecycle steps and cleaning. Passes CI. Reviewers noted minor dependency and container setup edge cases, which were clarified or deferred.
78%
#2222 lxd: support new style snap injection snapcraft merged Merged after implementing new style snap injection for LXD. Refactored provider logic, normalized code, and removed test duplication. Approved by two reviewers, passed CI, and verified via edge channel testing.
77%
#2631 spread tests: enable LXD build provider tests snapcraft merged Merged into master. Enabled LXD build provider tests by relocating setup to the early prepare phase to reduce overhead and consolidating declarations from task.yaml to spread.yaml. Approved, passed CI, and increased coverage by 0.01%.
75%
#2647 build providers: catch LXD socket error snapcraft merged Merged to catch LXD socket errors in build providers, resolving SNAPCRAFT-WA. Approved by reviewer, passed CI checks, and integrated with a 14-line addition and 6-line deletion across three files. Minor test coverage decrease noted but did not block merge.
74%
#302 test(spread): switch to testing in destructive mode imagecraft merged Switched spread tests to destructive mode and merged. This addresses an upcoming losetup requirement that temporarily breaks the LXD backend. Approved by two reviewers with passing CI checks.
72%
#3957 tests: retry installing lxd snap snapcraft merged Merged into main. Introduces retry logic for LXD snap installation in tests via snapd-testing-tools to workaround an intermittent snapd bug. Approved, passed CI, and caused no coverage changes.
72%
#42 feat(test-python): install lxd starflow merged Merged pull request to install lxd for test-python. This enables the use-lxd action required for craft-providers on hosted runners. Approved by reviewers and passed all CI checks.
72%
#3962 Setup snapd for snapcraft_legacy providers snapcraft merged Merged a fix for failing spread tests caused by missing snapd sockets in LXD containers. The change adopts snapd initialization logic from craft-providers to properly start the service, resolving connection errors. Approved and passed CI.
72%
#56 feat(test-python): optionally setup lxd starflow closed Merged after passing all CI checks. Adds optional LXD setup for craft-providers testing.
72%
#73 tests: remove duplicated unit tests rockcraft merged Merged removal of duplicated unit tests from test_provider.py and test_providers.py, artifacts from a prior LXD and Multipass test consolidation. Approved, passed CI, and reduced two files by 60 lines.
72%