tests: use lxd in clean provider test
Metadata
Current evaluation
Merged PR #3725 (commit 61aaff6fc) into snapcraft/7.0, enabling LXD in provider-cleaning unit tests so they match destructive-mode test runs. Approved by one maintainer reviewer.
Resolution: closed resolved
Reason: The PR itself was the resolution and was merged into the 7.0 branch at commit 61aaff6fc, adding the LXD flag to the clean-provider test (+3 lines) so tests run with LXD enabled as in destructive-mode CI. The only comment was an automated Codecov report noting no coverage change.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Tests are ordinarily conducted in destructive mode, enable lxd in
provider cleaning tests.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3725 (commit 61aaff6fc) into snapcraft/7.0, enabling LXD in provider-cleaning unit tests so they match destructive-mode test runs. Approved by one maintainer reviewer. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #3725 merged into snapcraft/7.0, enabling LXD in provider-cleaning tests to match destructive-mode testing (commit 61aaff6fc). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into snapcraft/7.0. Enables LXD in provider cleaning tests to align with destructive mode testing. Approved by one reviewer, passed CI checks, and maintained existing code coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into snapcraft/7.0. Updated provider cleaning tests to use LXD instead of destructive mode. Codecov confirmed zero coverage impact. The change enables LXD for cleaner test execution. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2983 tests: add LXD spread test | snapcraft | merged | Merged PR #2983 as 4b8522a14, adding spread coverage that builds the LXD package with LXD and destructive/host providers; installation checks were deferred. | |
| #2509 build providers: initial support for LXD | snapcraft | merged | Merged PR #2509 (commit 067024732) adding initial LXD build-provider support: `snapcraft --use-lxd` runs all lifecycle steps and clean inside an LXD container. Released via beta/lxd channel; LP bug #1805221 closed. | |
| #2631 spread tests: enable LXD build provider tests | snapcraft | merged | Merged PR #2631 enabled LXD build-provider spread tests and reused early-prepared LXD setup, reducing repeated setup and image-download overhead. | |
| #207 tests: split lxd integration tests | craft-providers | merged | Merged #207 to split LXD integration tests, resolving review feedback from #205; landed as commit 3eba5ca. | |
| #1805221 Build environment with lxd (--use-lxd) | snapcraft (launchpad) | closed | LXD build-provider support was implemented and merged in snapcraft PR #2509 (commit 067024732, "build providers: initial support for LXD"), making `snapcraft --use-lxd` run lifecycle steps and clean in an LXD container. Bug closed. | |
| #1807 tests: run test_cleanbuild in LXD on Travis | snapcraft | merged | Merged PR #1807 (commit 70df69b9a) by kalikiana, making test_cleanbuild run in LXD on Travis so it is no longer skipped when tests run as a snap; fixes LP #1738210. Reviewer asked to revert the last commit keeping LXD for cleanbuild only. | |
| #467 test(spread): use LXD provider for spread tests | imagecraft | closed | PR closed without merge; spread LXD provider changes were implemented across follow-up PRs (#483, #485, #486, #487, #488, #495) | |
| #31 lxd: introduce LXC to interface with lxc | craft-providers | merged | Merged PR adding the LXC wrapper class to craft_providers/lxd/lxc.py for all lxc CLI interaction (+2627/-0, 3 files). Merged as 38f233f (feature commit 0d400f6); integration tests landed separately in #32. | |
| #1415 tests: run the tests in travis using LXD containers | snapcraft | merged | Merged in snapcraft#1415 via commit 8c9a38cde, updating Travis CI to run the test suite in LXD containers. | |
| #483 test(spread): run snap-preseed tests in lxd | imagecraft | merged | Merged PR #483 to update snap-preseed plugin tests to run in LXD across all systems, addressing CRAFT-5332. |