← Back to issue list

Ignore less of ruff's warnings

View original Github issue

Metadata

Project
craft-providers
Number
#325
Type
issue
State
closed
Author
mr-cal
Labels
good first issue Type: Enhancement
Created
Updated
Closed

Current evaluation

Closed as stale after maintainers found the linked configuration outdated; current Ruff ignores match Starbase, except one valid craft-providers-specific S108 ignore.

Resolution: closed stale

Reason: Maintainers determined the issue referenced an old pyproject.toml permalink and that craft-providers was already aligned with Starbase. PR #965 was closed unmerged because the remaining rules were intentionally ignored.

Evaluated by: mr-cal-bot

No scores available.

Issue body

There are ~30 `ruff` linting rules from `starbase` that are [disabled](https://github.com/canonical/craft-providers/blob/4bdf2b75a249648ba067fb07db6c40e64112ee9a/pyproject.toml#L237-L268) in `craft-providers`. These should either be fixed or include a reason why they are disabled.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale Closed as stale after maintainers found the linked configuration outdated; current Ruff ignores match Starbase, except one valid craft-providers-specific S108 ignore.
stealth/space-bunny-alpha — closed stale Closed as stale: most Ruff ignores matched Starbase, and the sole craft-providers-specific ignore was valid. Proposed #965 was rejected because the remaining rules are intentionally ignored.
qwen/qwen3.6-35b-a3b — — Closed as stale. Maintainers confirmed the disabled ruff rules are intentionally ignored to avoid future lint noise, not because they fail. The repository is already compliant with current standards, so no changes were made.
qwen/qwen3.6-35b-a3b — — Closed as stale. Disabled Ruff rules were intentionally suppressed to prevent future lint noise, not because they were failing. The project is already aligned with Starbase's standards, leaving only one valid project-specific ignore. No changes.
qwen3.6-35b-a3b-mtp-q6 — — Closed as stale. Maintainers determined the disabled Ruff rules were intentionally ignored to prevent future violations. The project is already aligned with Starbase's linting standards, requiring no changes.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-providers#965 (confidence 99%)

    Proposed enabling Ruff rules D215, A003, and PLW1641, but was rejected because those ignores intentionally match Starbase.

Related issues

Issue Project State Summary Similarity
#56 lint: stricter ruff rules starbase closed Closed unmerged because the stricter Ruff configuration landed through canonical/starbase#55 in commit b5cda0d.
72%