lint: stricter ruff rules
Metadata
Current evaluation
Closed unmerged because the stricter Ruff configuration landed through canonical/starbase#55 in commit b5cda0d.
Resolution: closed superseded
Reason: Merged canonical/starbase#55 delivered the stricter Ruff configuration in commit b5cda0d. The duplicate implementation in #56 was therefore closed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged because the stricter Ruff configuration landed through canonical/starbase#55 in commit b5cda0d. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; the stricter Ruff configuration was delivered by merged PR canonical/starbase#55 in commit b5cda0d. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The pull request applying stricter ruff linting rules remained in pending review with no comments or CI checks and was abandoned. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merge or comments, indicating the stricter ruff linting rules were abandoned or superseded. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/starbase#55
(confidence 99%)
The equivalent Ruff configuration change was merged through #55.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #55 lint: stricter ruff rules | starbase | merged | Merged PR canonical/starbase#55 as b5cda0d, tightening Ruff lint rules in one file (+23/-9) after maintainer approval. | |
| #165 style: fix linting for ruff 0.12 | imagecraft | merged | Merged #165, incorporating canonical/starbase#408, with a four-file Ruff 0.12 compatibility style update (+7/-7). | |
| #264 lint: format with ruff and fix ruff linting errors | rockcraft | closed | Ruff formatting and lint cleanup in #264 was closed unmerged after remaining unreviewed. Prerequisite #263 merged as 4abd39c2, while later Ruff adoption continued in #363. | |
| #582 style: ruff 0.16 | starbase | merged | Merged starbase#582 ("style: ruff 0.16", +1/-0) by maintainer mr-cal, adding PLR0917 (too many positional arguments) to the per-file Ruff ignores for tests. | |
| #139 style: stricter ruff linters | starbase | merged | PR #139 was merged as commit a48d590, adding stricter Ruff lint rules across six files while retaining 100% test coverage. | |
| #444 fix: resolve ruff and ty lint findings | craft-store | merged | Merged to fix ruff and ty lint findings and update ruff config, preparing for the Starbase sync in #440. | |
| #33 lint: fix lint issues with newer ruff | craft-archives | merged | PR #33 merged as commit c2a6687, fixing new lint failures introduced by a newer Ruff release across3 files (+5/-3). Maintainer deferred extra unit tests to CRAFT-1641. | |
| #263 tools: add ruff config | rockcraft | merged | Merged PR #263 added Starbase’s Ruff configuration and a Makefile test-ruff target; merged as commit 4abd39c2. | |
| #325 Ignore less of ruff's warnings | craft-providers | closed | Closed as stale after maintainers found the linked configuration outdated; current Ruff ignores match Starbase, except one valid craft-providers-specific S108 ignore. | |
| #4712 Move more linting to ruff | snapcraft | closed | Ruff linting was completed and aligned with Starbase; pylint and isort were removed in #4817 and commit a00f1c439, followed by pylint cleanup in #4848. |