fix type checking
Metadata
Current evaluation
Replaced by the move to ty type checking in #885 (28ccfe5); legacy mypy and pyright checks were removed in #1007 (232143d).
Resolution: closed superseded
Reason: The requested strict pyright and mypy work was replaced by a different type checker: #885 enabled ty in commit 28ccfe5. PR #1007 later removed mypy and pyright in commit 232143d, making the original implementation obsolete.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Craft-providers' typing is not up to `starbase`'s standards for type checking and should be improved.
This includes:
* enable [strict type checking](https://github.com/canonical/craft-providers/blob/4bdf2b75a249648ba067fb07db6c40e64112ee9a/pyproject.toml#L114-L115) with `pyright`
* enable [remaining](https://github.com/canonical/craft-providers/blob/4bdf2b75a249648ba067fb07db6c40e64112ee9a/pyproject.toml#L131-L134) `mypy` checks
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Replaced by the move to ty type checking in #885 (28ccfe5); legacy mypy and pyright checks were removed in #1007 (232143d). | |
| stealth/space-bunny-alpha | — | closed stale | Closed without a documented fix. Type checking later moved to ty in #885; mypy and pyright were removed in #1007. | |
| qwen/qwen3.6-35b-a3b | — | — | The enhancement to enable strict pyright and mypy type checking was closed without an associated pull request or fix. No resolution details were provided, indicating the request was abandoned or superseded. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
60
Quick Win:
36
Staleness:
70
Complexity:
40
Confidence:
60
Support Request:
0
|
close stale | Enhancement to improve type checking with pyright strict mode and mypy. Issue is 1172 days old; project has since migrated to ty and dropped mypy/pyright. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
85
Complexity:
40
Confidence:
75
Support Request:
5
|
close stale | Type-checking enhancement requesting strict pyright and mypy configurations. Open for over 3 years with only automated bot activity recently, indicating no active development or maintainer prioritization. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
70
Complexity:
30
Confidence:
85
Support Request:
5
|
keep open | Enhancement to enable strict pyright and mypy type checking to match starbase standards. Labeled as good first issue, but has seen no human engagement in years, only a Jira sync bot comment recently. |
Update history
| Date | Change |
|---|---|
| closed |
Related work
-
Superseded By:
canonical/craft-providers#885
(confidence 98%)
Enabled type checking with ty in commit 28ccfe5, replacing the requested mypy/pyright approach.
-
Related To:
canonical/craft-providers#1007
(confidence 96%)
Removed mypy and pyright in commit 232143d after the migration to ty.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #263 Migrate type checking to ty. | imagecraft | closed | Type checking was migrated from mypy/pyright to ty by merged PR #328, commit fc21f39. |