fix type checking
Metadata
Current evaluation
Enhancement to improve type checking with pyright strict mode and mypy. Issue is 1172 days old; project has since migrated to ty and dropped mypy/pyright.
Suggested action: close stale
Reason: The issue requests enabling strict type checking with pyright and mypy, but the project has since migrated to using "ty" for type checking (commit #885) and explicitly dropped mypy/pyright (commit #1007). The specific tools mentioned are no longer used, making the original request obsolete even though type checking is still being addressed with different tooling.
Impact:
60
Quick Win:
36.0
Staleness:
70
Complexity:
40
Confidence:
60
Support Request:
0
Issue body
Craft-providers' typing is not up to `starbase`'s standards for type checking and should be improved.
This includes:
* enable [strict type checking](https://github.com/canonical/craft-providers/blob/4bdf2b75a249648ba067fb07db6c40e64112ee9a/pyproject.toml#L114-L115) with `pyright`
* enable [remaining](https://github.com/canonical/craft-providers/blob/4bdf2b75a249648ba067fb07db6c40e64112ee9a/pyproject.toml#L131-L134) `mypy` checks
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
60
Quick Win:
36.0
Staleness:
70
Complexity:
40
Confidence:
60
Support Request:
0
|
close stale | Enhancement to improve type checking with pyright strict mode and mypy. Issue is 1172 days old; project has since migrated to ty and dropped mypy/pyright. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
85
Complexity:
40
Confidence:
75
Support Request:
5
|
close stale | Type-checking enhancement requesting strict pyright and mypy configurations. Open for over 3 years with only automated bot activity recently, indicating no active development or maintainer prioritization. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
70
Complexity:
30
Confidence:
85
Support Request:
5
|
keep open | Enhancement to enable strict pyright and mypy type checking to match starbase standards. Labeled as good first issue, but has seen no human engagement in years, only a Jira sync bot comment recently. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
88
Complexity:
20
Confidence:
75
Support Request:
5
|
close stale | Long-standing enhancement to enable strict pyright and mypy type checking. Open for over 3 years with no contributor traction or maintainer follow-up. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
craft-providers#1007
(confidence 70%)
Commit #1007 dropped mypy and pyright in favor of ty for type checking, rendering the original request obsolete.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #901 Remove mypy and pyright | craft-providers | open | Enhancement to remove mypy and pyright type checkers in favor of ty, following similar work in snapcraft#6007. Issue created by maintainer but has had no maintainer response or comments in 136 days. | |
| #1294 style: enable strict type checking with pyright | craft-parts | merged | Merged PR enabling strict type checking with pyright. All resulting type errors were resolved, improving the project's typing and linting status. The change passed CI checks and was approved, successfully integrating stricter type safety. | |
| #1706 style: drop mypy, pyright | craft-parts | merged | Merged after approval and passing CI. Replaced mypy and pyright with ty for type checking across 88 files. Redundant isinstance checks were deferred to a separate issue. | |
| #1314 Type checking: enable stricter mypy rules | charmcraft | closed | Superseded by a switch to the ty type checker. The request to enable stricter mypy rules was closed without implementation. | |
| #215 style: drop mypy, pyright | craft-grammar | merged | Merged a pull request replacing mypy and pyright with the ty type checker. After passing all CI checks and receiving two approvals, the change was successfully integrated, removing 481 lines of configuration across six files. | |
| #223 style: switch from mypy+pyright to ty | craft-platforms | merged | Merged after approval by two reviewers and passing CI checks. Replaces mypy and pyright with the ty type checker across three files, reducing 266 lines. | |
| #1007 style: drop mypy, pyright | craft-providers | merged | Removes mypy and pyright type checkers in favor of ty, updating Makefile, common.mk, pyproject.toml, and uv.lock across 16 files (+24/-241). Fresh maintainer PR, CI green, pending review; directly implements issue #901. |