← Back to issue list

style: enable type checking with ty

View original Github issue

Metadata

Project
craft-providers
Number
#885
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed.

Resolution: closed resolved

Reason: PR #885 received two approvals, reported no failing CI checks, and merged as commit 28ccfe5. The change enabled static type checking with ty.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed.
qwen/qwen3.6-35b-a3b — closed resolved Merged PR enabling type checking with the ty tool, modifying 8 files (+62/-36 lines) to improve static type analysis coverage.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#27 ci: type check with ty craft-artifacts merged Merged PR #27 as commit 716f05a, adding ty type checking to CI and suppressing intentional type violations; related lint fixes landed in #20.
84%
#1698 style: ty craft-parts merged Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
82%
#938 style: ty craft-providers merged Merged PR #938 as commit 44bcd1a, adding targeted ty suppressions across 8 files to ignore warnings introduced by the latest ty version.
78%
#139 style(type): fix typing issues found by ty craft-platforms merged Merged as commit 1a30eec, fixing type-checking edge cases found by ty; the remaining diagnostic was an upstream false positive tracked in astral-sh/ty#553.
77%
#2370 ci: add experimental workflow using ty for type checking charmcraft merged Merged PR #2370 (commit d06324ff) added an experimental ty type-checking workflow; CI passed and reported ty diagnostics were informational.
77%
#910 style: fix ty error craft-providers merged Merged in #910 via commit 30fc806, adding a targeted suppression for a ty false positive; all listed CI checks passed.
77%
#242 style: fix ty linting error craft-platforms merged Merged PR #242 with a one-line fix for the ty linting error; the change landed as commit e8b89ce.
77%
#6280 style: ty 0.0.44 snapcraft merged Merged PR #6280 in commit 8b45efc80, applying ty 0.0.44 style updates after two approvals; unrelated CI failures did not block the merge.
76%
#1126 style: fix ty errors craft-application merged Merged PR #1126 (commit 9f5e0e76): small +8/-10 style fix taking advantage of ty's new Pydantic support, clearing remaining type-checker errors.
76%
#132 ci(experimental): type check with ty craft-platforms merged PR #132 merged, adding experimental ty type checking to CI; detected type errors were retained as non-blocking notifications.
76%