← Back to issue list

tests: refactor verify_network and DEFAULT_FAKE_CMD usage

View original Github issue

Metadata

Project
craft-providers
Number
#380
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

PR #380 by mr-cal merged into main as commit 695a7cc, a test-only refactor of verify_network/DEFAULT_FAKE_CMD usage (+41/-96, 5 files) preparing for #184 (Use `snap refresh --hold`, fixed in 09ef06f).

Resolution: closed resolved

Reason: The pull request itself was merged into main, landing as commit 695a7cc ('tests: refactor verify_network and DEFAULT_FAKE_CMD usage (#380)') with two approving reviewers. It was a preparatory test refactor for issue #184.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- Some minor test refactoring in preparation for #184. (CRAFT-1984)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #380 by mr-cal merged into main as commit 695a7cc, a test-only refactor of verify_network/DEFAULT_FAKE_CMD usage (+41/-96, 5 files) preparing for #184 (Use `snap refresh --hold`, fixed in 09ef06f).
qwen/qwen3.6-35b-a3b — closed resolved Merged test refactoring for verify_network and DEFAULT_FAKE_CMD usage to prepare for #184.

Update history

Date Change
created

Related work

  • Related To: canonical/craft-providers#184 (confidence 92%)

    PR body states the refactor is 'in preparation for #184' (Use `snap refresh --hold`), which was later fixed in commit 09ef06f.

Related issues

Issue Project State Summary Similarity
#1569 tests: refactor the fake snapd to not hardcode values snapcraft merged Merged PR #1569 as commit cf2a0bf0a, refactoring fake snapd tests to remove hardcoded values; it was a required follow-up to #1567.
75%
#1799 tests: update the registered snap fake snapcraft merged Merged #1799, a test-only update to the registered snap fake changing four lines across two files; it received one approval with no unresolved comments.
71%