← Back to issue list

tests: update the registered snap fake

View original Github issue

Metadata

Project
snapcraft
Number
#1799
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged following approval by one reviewer. Updated the registered snap fake in tests, changing 2 files with 4 additions and 4 deletions.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged following approval by one reviewer. Updated the registered snap fake in tests, changing 2 files with 4 additions and 4 deletions.
qwen3.6-35b-a3b-mtp-q6 Merged. Updates the registered snap fake test fixture to align with current snap registration expectations, ensuring unit tests pass. No further review or follow-up was required.
qwen3.6-35b-a3b-mtp-q6 Merged updates to the registered snap fake in the test suite. Changes passed static and unit tests, updating test fixtures to match current requirements.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1569 tests: refactor the fake snapd to not hardcode values snapcraft merged Merged PR refactoring fake snapd tests to remove hardcoded values. Approved by two reviewers, CI passed. Six files changed with 238 additions and 126 deletions. Requires PR #1567.
79%
#1724 tests: use the common base handler on the fake snapd server snapcraft merged Merged updates to the fake snapd server test handler to prevent debug output from leaking into stdout and interfering with other tests. Approved, passed CI, and applied with a minimal three-line change.
73%
#2352 tests: use valid snap names in unit tests snapcraft merged Merged updates to unit tests that replace invalid snap names with valid ones, ensuring compatibility with snap pack --check-skeleton. The author approved and merged the minor change directly without external review.
73%
#1849 tests: add snap not found tests snapcraft merged Merged tests for missing snap scenarios. Approved by two reviewers and integrated into the codebase despite unresolved review comments and reported integration test timeouts.
73%
#1797 tests: update the snap name already registered for store tests snapcraft merged Merged test update replacing a revoked snap name with an active one to match current store responses. Transient CI timeouts were retried before final merge.
72%
#46 tests: add fake snapd fixture craft-parts merged Merged after two approvals and passing CI. Introduces a fake snapd fixture to test snap package handling in craft-parts.packages. Adds 212 lines across two files. Windows compatibility limitations were noted for separate follow-up.
72%
#629 Proper message when registering an already registered snap snapcraft merged Merged changes improving the error message when registering an already registered snap. The update modifies four files (+38/-3 lines). Approved and tested on fake and staging servers by @come-maiz.
72%
#521 test(spread): add an improved snap inspector test fetch-service merged Merged an improved snap inspector test that emulates system setup by stopping snapd, clearing device files, setting a global proxy, and restarting snapd to uncover network requests. Approved by two reviewers, passed all CI checks, and merged.
71%