tests: update the registered snap fake
Metadata
Current evaluation
Merged #1799, a test-only update to the registered snap fake changing four lines across two files; it received one approval with no unresolved comments.
Resolution: closed resolved
Reason: PR #1799 was merged after an approving review. Its +4/-4 change updates the registered snap fake used by tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1799, a test-only update to the registered snap fake changing four lines across two files; it received one approval with no unresolved comments. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged test-only update to the registered snap fake (+4/-4 across two files), with one approving reviewer and no unresolved comments. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following approval by one reviewer. Updated the registered snap fake in tests, changing 2 files with 4 additions and 4 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updates the registered snap fake test fixture to align with current snap registration expectations, ensuring unit tests pass. No further review or follow-up was required. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1569 tests: refactor the fake snapd to not hardcode values | snapcraft | merged | Merged PR #1569 as commit cf2a0bf0a, refactoring fake snapd tests to remove hardcoded values; it was a required follow-up to #1567. | |
| #1797 tests: update the snap name already registered for store tests | snapcraft | merged | Updated store tests to use a currently registered, non-revoked snap after the previous test name was revoked; merged as commit 4cf4f33a. | |
| #46 tests: add fake snapd fixture | craft-parts | merged | Merged PR #46 as 64fdf574 (feature commit 9db65074), adding a 212-line fake snapd fixture for testing snap package handling in craft-parts.packages. | |
| #380 tests: refactor verify_network and DEFAULT_FAKE_CMD usage | craft-providers | merged | PR #380 by mr-cal merged into main as commit 695a7cc, a test-only refactor of verify_network/DEFAULT_FAKE_CMD usage (+41/-96, 5 files) preparing for #184 (Use `snap refresh --hold`, fixed in 09ef06f). | |
| #2352 tests: use valid snap names in unit tests | snapcraft | merged | Merged PR #2352 (commit b8c0a4fbf) changed snap names used in unit tests so they pass snap pack --check-skeleton; author merged directly as a minor test-only change. | |
| #2351 tests: use valid snap names in unit tests | snapcraft | closed | Closed unmerged; the same test-only change was merged instead via PR #2352 (commit b8c0a4fbf), updating unit-test snap names to pass `snap pack --check-skeleton`. |