craft-store is not compatible with keyring 25.x
Metadata
Current evaluation
Fixed keyring 25 compatibility with workaround 6ef080b and full fix PR #206, merged as bdcbf0e.
Resolution: closed resolved
Reason: The removed keyring._compat dependency was replaced with a supported implementation. The initial workaround was commit 6ef080b, followed by the full compatibility fix in PR #206 at commit bdcbf0e.
Evaluated by: mr-cal-bot
No scores available.
Issue body
### Bug Description
craft-store uses a private _compat module in keyring, which is removed in keyring 25.
### To Reproduce
See: https://github.com/canonical/snapcraft/actions/runs/8437694793/job/23108074098?pr=4693#step:4:364
### part yaml
_No response_
### Relevant log output
```shell
Traceback (most recent call last):
File "/home/runner/work/snapcraft/snapcraft/.tox/docs/lib/python3.10/site-packages/sphinx/config.py", line 358, in eval_config_file
exec(code, namespace) # NoQA: S102
File "/home/runner/work/snapcraft/snapcraft/docs/conf.py", line 12, in <module>
import snapcraft
File "/home/runner/work/snapcraft/snapcraft/snapcraft/__init__.py", line 23, in <module>
import snapcraft.sources # noqa: F401
File "/home/runner/work/snapcraft/snapcraft/snapcraft/sources.py", line 22, in <module>
from snapcraft_legacy.sources import get
File "/home/runner/work/snapcraft/snapcraft/snapcraft_legacy/__init__.py", line 352, in <module>
from snapcraft_legacy._store import ( # noqa
File "/home/runner/work/snapcraft/snapcraft/snapcraft_legacy/_store.py", line 30, in <module>
import craft_store
File "/home/runner/work/snapcraft/snapcraft/.tox/docs/lib/python3.10/site-packages/craft_store/__init__.py", line 23, in <module>
from .auth import Auth
File "/home/runner/work/snapcraft/snapcraft/.tox/docs/lib/python3.10/site-packages/craft_store/auth.py", line 32, in <module>
from keyring._compat import properties
ModuleNotFoundError: No module named 'keyring._compat'
```
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Fixed keyring 25 compatibility with workaround 6ef080b and full fix PR #206, merged as bdcbf0e. | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed for keyring 25: a workaround merged in #163 (6ef080b), followed by the full compatibility fix in #206 (bdcbf0e). | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution. An internal Jira ticket (CRAFT-2653) was created to track the keyring 25.x incompatibility, but no code changes or merge details were provided. The issue appears abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution. The only activity was an automated Jira ticket creation. The keyring 25.x incompatibility caused by a removed private _compat module remains unaddressed. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
craft-store#206
(confidence 99%)
Merged full fix for keyring 25 compatibility.
-
Related To:
craft-store#163
(confidence 95%)
Contained the initial workaround merged as commit 6ef080b.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #206 fix: make compatible with keyring 25 | craft-store | merged | Merged canonical/craft-store#206 in commit bdcbf0e, adding a two-file compatibility fix for keyring 25 and resolving issue #162. | |
| #163 fix: workaround for keyring 25 incompatibility | craft-store | merged | Merged a one-line workaround for keyring 25 incompatibility in commit 6ef080b, addressing canonical/craft-store#162. |