fix: make compatible with keyring 25
Metadata
Current evaluation
Merged canonical/craft-store#206 in commit bdcbf0e, adding a two-file compatibility fix for keyring 25 and resolving issue #162.
Resolution: closed resolved
Reason: The approved PR was merged as commit bdcbf0e, completing compatibility with keyring 25 and fixing canonical/craft-store#162.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes #162
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/craft-store#206 in commit bdcbf0e, adding a two-file compatibility fix for keyring 25 and resolving issue #162. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-store#206 via commit bdcbf0e, adding a two-file compatibility fix for keyring 25 and resolving #162. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to resolve issue #162 by updating code for keyring 25 compatibility. Approved by three reviewers, the change modifies two files with minimal adjustments (+3/-2 lines) and was successfully integrated. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-store#162
(confidence 100%)
The keyring 25 incompatibility issue explicitly fixed by this merged PR.
-
Related To:
canonical/craft-store#163
(confidence 90%)
Merged earlier as commit 6ef080b to provide a keyring 25 workaround.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #163 fix: workaround for keyring 25 incompatibility | craft-store | merged | Merged a one-line workaround for keyring 25 incompatibility in commit 6ef080b, addressing canonical/craft-store#162. | |
| #162 craft-store is not compatible with keyring 25.x | craft-store | closed | Fixed keyring 25 compatibility with workaround 6ef080b and full fix PR #206, merged as bdcbf0e. | |
| #1388 build(deps): bump craft-store to 2.5.0 | charmcraft | merged | Merged PR #1388 as commit 70066d49, upgrading craft-store to 2.5.0 to add a file-based keyring fallback on headless systems and fix #719. | |
| #4455 build(deps): bump craft-store to 2.5.0 | snapcraft | merged | Merged PR #4455 (commit 9b5c2f4cf) bumped craft-store to 2.5.0, enabling headless systems to use a file-based keyring fallback for login. | |
| #390 fix(auth): error more nicely on keyring errors | craft-store | merged | Merged PR #390 (commit d87f1bd) broadens keyring error handling, wrapping more keyring failures as KeyringUnlockError. Fixes #58 and ships in craft-store 3.4.0. | |
| #75 auth: handle keyring unlocking errors | craft-store | merged | Merged PR #75 as commit 74a2ed4, adding keyring unlock error handling that raises a Craft-store error instead of exposing the backend exception. | |
| #38 auth: avoid MemoryKeyring in keyring and raise appropriately (CRAFT-771) | craft-store | merged | Merged in canonical/craft-store#38 via d7ee75f, preventing automatic MemoryKeyring selection and raising NoKeyringError during StoreClient initialization when no keyring exists. | |
| #1650 chore(deps): update dependency keyring to v25 | charmcraft | closed | Renovate's keyring 25.1.0 update was closed unmerged because keyring 25 compatibility was blocked by canonical/craft-store#162; future 25.x updates were ignored. | |
| #170 fix: catch keyring locked error | craft-store | merged | Merged PR #170 added handling for locked keyring errors, fixing #166; merged as commit ee19448. |