← Back to issue list

fix: workaround for keyring 25 incompatibility

View original Github issue

Metadata

Project
craft-store
Number
#163
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a one-line workaround to resolve keyring 25 incompatibility. Approved by two reviewers and passed CI checks, addressing issue #162.

Suggested action:

No scores available.

Issue body

https://github.com/canonical/craft-store/issues/162 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a one-line workaround to resolve keyring 25 incompatibility. Approved by two reviewers and passed CI checks, addressing issue #162.
qwen3.6-35b-a3b-mtp-q6 Merged a workaround resolving keyring 25 incompatibility, addressing canonical/craft-store#162. The change passed tox tests and was integrated by maintainer lengau.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#206 fix: make compatible with keyring 25 craft-store merged Merged to resolve issue #162 by updating code for keyring 25 compatibility. Approved by three reviewers, the change modifies two files with minimal adjustments (+3/-2 lines) and was successfully integrated.
87%
#170 fix: catch keyring locked error craft-store merged Merged to resolve issue #166 by catching the keyring locked error. Approved by two reviewers with a two-line change in one file.
82%
#390 fix(auth): error more nicely on keyring errors craft-store merged Merged to improve keyring unlock error handling by catching additional failures and raising them as KeyringUnlockError. Approved by three reviewers, passed all CI checks, and resolves issue #58.
74%
#1046 fix: add keyrings to standard chroot mount craft-parts merged Merged after reviewer approval and passing CI. Adds the keyrings directory to standard chroot mounts to enable archive signature verification during apt-upgrade in noble build-bases. Squash-merged to bypass unrelated CI failures.
71%
#50 keys: handle keyring path parents not existing craft-archives merged Merged changes to handle non-existent keyring path parents. Approved by two reviewers, modified three files (+19/-4), and achieved 100% diff coverage. Required for rockcraft PR #217.
70%