← Back to issue list

chore: update ruff pre-commit away from legacy

View original Github issue

Metadata

Project
craft-store
Number
#380
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a minimal update replacing the legacy ruff pre-commit hook with the new ruff-check variant. Approved by reviewers and passing CI checks, the change successfully modernizes the project's linting configuration.

Suggested action:

No scores available.

Issue body

We were still using the legacy `ruff` pre-commit hook rather than the new `ruff-check` one. This fixes that. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/craft-store/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a minimal update replacing the legacy ruff pre-commit hook with the new ruff-check variant. Approved by reviewers and passing CI checks, the change successfully modernizes the project's linting configuration.
qwen3.6-35b-a3b-mtp-q6 Merged. Replaced the legacy ruff pre-commit hook with the new ruff-check hook to modernize the project's linting configuration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#562 chore: use the non-legacy ruff check pre-commit hook starbase merged Merged to replace the deprecated ruff pre-commit hook with the non-legacy ruff-check hook. Approved by two reviewers, passed all CI checks, and committed with a single line change.
90%
#700 chore: update ruff craft-parts merged Merged after approval by two reviewers and passing CI checks. Updates ruff configuration across four files, supersedes #699, and resolves a lint issue addressed in #702.
83%
#1347 chore(deps): update ruff and fix new linting errors charmcraft merged Merged after updating the ruff dependency and fixing new linting errors. Modifications were largely autoformatted across ten files. The changes received dual reviewer approval, passed CI checks, and were successfully integrated.
82%
#4417 chore(deps): update ruff to 0.1.1 and fix lint issues snapcraft merged Merged dependency update upgrading ruff to 0.1.1 and resolving linting errors across 19 files. Approved by two reviewers, passed CI, and increased coverage by 0.01%. A newer ruff version was released shortly after merge.
82%
#115 chore(deps): update ruff and fix linting issue craft-application merged Merged into main after two approvals and passing CI. The update refreshed the ruff dependency and resolved a linting issue across two files. Codecov recorded a negligible 0.10% coverage decrease upon merge.
80%
#200 chore(deps): update ruff and its configuration craft-application merged Merged an update to ruff and its configuration. Approved by two reviewers with passing CI checks. The change modified one file with five additions and five deletions.
80%
#137 chore(deps): update dependency lint/ruff to v0.1.7 craft-store merged Merged an automated Renovate update upgrading lint/ruff from v0.1.1 to v0.1.7. Approved by two reviewers, passed CI, and merged with a single-line configuration change.
80%
#172 chore(deps): update dependency lint/ruff to v0.1.11 craft-application merged Merged a Renovate-generated update upgrading lint/ruff from v0.1.7 to v0.1.11. The change passed CI checks, maintained 99.20% test coverage, received two approvals, and was successfully merged.
80%
#1683 chore: explicitly use the 'check' command to avoid ruff warning about it charmcraft merged Merged an external contribution updating templates to explicitly use the ruff check command. This aligns with modern ruff syntax, eliminating deprecation warnings. Approved by two reviewers and passed CI checks.
80%
#230 chore(deps): update dependency lint/ruff to v0.1.15 craft-cli merged Merged automated dependency update upgrading lint/ruff from v0.1.14 to v0.1.15. Approved by two reviewers, passed CI checks, and maintained 94.81% test coverage across a single file change.
80%