chore: update ruff pre-commit away from legacy
Metadata
Current evaluation
Merged PR #380 (commit fc75854) replaced the legacy `ruff` pre-commit hook with the new `ruff-check` id in .pre-commit-config.yaml, a one-line lint config change approved by 2 reviewers.
Resolution: closed resolved
Reason: PR was merged as commit fc75854 into main with two approvals and no unresolved comments; the resulting hook id `ruff-check` is present in the current .pre-commit-config.yaml, confirming the change landed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
We were still using the legacy `ruff` pre-commit hook rather than the new `ruff-check` one. This fixes that.
---
- [ ] I've followed the [contribution guidelines](https://github.com/canonical/craft-store/blob/main/CONTRIBUTING.md).
- [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [ ] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #380 (commit fc75854) replaced the legacy `ruff` pre-commit hook with the new `ruff-check` id in .pre-commit-config.yaml, a one-line lint config change approved by 2 reviewers. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #380 (commit fc75854), replacing the legacy ruff pre-commit hook with ruff-check in the lint configuration. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a minimal update replacing the legacy ruff pre-commit hook with the new ruff-check variant. Approved by reviewers and passing CI checks, the change successfully modernizes the project's linting configuration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Replaced the legacy ruff pre-commit hook with the new ruff-check hook to modernize the project's linting configuration. |
Update history
No update history recorded yet.
Related work
-
Related To:
starbase#562
(confidence 85%)
Upstream starbase PR (commit ba42dd9) made the identical legacy-to-ruff-check hook change; craft-store's change tracks it.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #562 chore: use the non-legacy ruff check pre-commit hook | starbase | merged | PR #562 by maintainer lengau renamed the deprecated `ruff` pre-commit hook to `ruff-check` in .pre-commit-config.yaml (+1/-1 line). Merged to main as commit ba42dd9 with all CI checks passing. | |
| #230 chore(deps): update dependency lint/ruff to v0.1.15 | craft-cli | merged | Renovate PR merged (commit e68b0c7), bumping the ruff lint hook from 0.1.14 to 0.1.15 in .pre-commit-config.yaml; approved by two reviewers with no CI failures. | |
| #1347 chore(deps): update ruff and fix new linting errors | charmcraft | merged | Ruff pre-commit hook was bumped and resulting lint errors auto-fixed across 10 files (+40/-37). PR #1347 was merged by lengau on 2023-10-23 as commit 34018724. | |
| #131 chore(deps): update dependency lint/ruff to v0.0.291 | starbase | merged | Renovate dependency bump of lint/ruff from v0.0.290 to v0.0.291 in .pre-commit-config.yaml was approved and merged into main as commit c3c3313. | |
| #119 chore(deps): update dependency lint/ruff to v0.0.284 | starbase | merged | Renovate dependency bump PR #119 (lint/ruff 0.0.272 -> 0.0.284 in the ruff pre-commit hook) was approved and merged into main as commit be3ae62; +1/-1 line, no source changes. | |
| #115 chore(deps): update ruff and fix linting issue | craft-application | merged | Routine housekeeping PR bumping the ruff pre-commit hook and fixing the resulting lint error (2 files, +2/-4). Approved by 2 reviewers and merged into main as commit 59ab0049; Codecov's -0.10% coverage note was non-blocking. | |
| #1346 chore(deps): update dependency ruff to v0.1.1 | charmcraft | closed | Renovate's ruff 0.0.282->0.1.1 bump PR was closed unmerged by lengau as superseded by #1347, which updated the ruff pre-commit hook and auto-fixed new lint errors (merged 2023-10-23, commit 34018724). | |
| #700 chore: update ruff | craft-parts | merged | Merged PR #700 updated Ruff configuration across four files, superseding #699; a follow-up lint issue was fixed in merged PR #702. | |
| #36 chore: switch to ruff | craft-platforms | merged | Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files. | |
| #113 update ruff pre-commit | craft-platforms | merged | Merged #113, updating Ruff's pre-commit configuration; the change landed in commit 1740611. |