← Back to issue list

chore: use the non-legacy ruff check pre-commit hook

View original Github issue

Metadata

Project
starbase
Number
#562
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR #562 by maintainer lengau renamed the deprecated `ruff` pre-commit hook to `ruff-check` in .pre-commit-config.yaml (+1/-1 line). Merged to main as commit ba42dd9 with all CI checks passing.

Resolution: closed resolved

Reason: The PR was merged into main as commit ba42dd9 ("chore: use the non-legacy ruff check pre-commit hook (#562)"), approved by two reviewers with all CI checks green. The current .pre-commit-config.yaml confirms the hook is now `id: ruff-check`.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The `ruff` pre-commit hook is a legacy one replaced with `ruff-check`. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #562 by maintainer lengau renamed the deprecated `ruff` pre-commit hook to `ruff-check` in .pre-commit-config.yaml (+1/-1 line). Merged to main as commit ba42dd9 with all CI checks passing.
stealth/space-bunny-alpha — closed resolved Merged PR #562 replaced the legacy ruff pre-commit hook with ruff-check, updating one configuration line; commit ba42dd9.
qwen/qwen3.6-35b-a3b — — Merged to replace the deprecated ruff pre-commit hook with the non-legacy ruff-check hook. Approved by two reviewers, passed all CI checks, and committed with a single line change.
qwen3.6-35b-a3b-mtp-q6 — — Merged the update to replace the legacy ruff pre-commit hook with the non-legacy ruff-check hook, updating the project linting configuration to use the current recommended tool.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/starbase#561 (confidence 60%)

    Immediately preceding ruff pre-commit hook bump (58d539b); later Dependabot bumps #569/#571/#575/#580 continue the same hook.

Related issues

Issue Project State Summary Similarity
#380 chore: update ruff pre-commit away from legacy craft-store merged Merged PR #380 (commit fc75854) replaced the legacy `ruff` pre-commit hook with the new `ruff-check` id in .pre-commit-config.yaml, a one-line lint config change approved by 2 reviewers.
92%
#1347 chore(deps): update ruff and fix new linting errors charmcraft merged Ruff pre-commit hook was bumped and resulting lint errors auto-fixed across 10 files (+40/-37). PR #1347 was merged by lengau on 2023-10-23 as commit 34018724.
81%
#230 chore(deps): update dependency lint/ruff to v0.1.15 craft-cli merged Renovate PR merged (commit e68b0c7), bumping the ruff lint hook from 0.1.14 to 0.1.15 in .pre-commit-config.yaml; approved by two reviewers with no CI failures.
80%
#115 chore(deps): update ruff and fix linting issue craft-application merged Routine housekeeping PR bumping the ruff pre-commit hook and fixing the resulting lint error (2 files, +2/-4). Approved by 2 reviewers and merged into main as commit 59ab0049; Codecov's -0.10% coverage note was non-blocking.
79%
#119 chore(deps): update dependency lint/ruff to v0.0.284 starbase merged Renovate dependency bump PR #119 (lint/ruff 0.0.272 -> 0.0.284 in the ruff pre-commit hook) was approved and merged into main as commit be3ae62; +1/-1 line, no source changes.
78%
#1683 chore: explicitly use the 'check' command to avoid ruff warning about it charmcraft merged PR #1683 merged as commit b48b8c59: charmcraft init templates now invoke `ruff check` explicitly in the tox lint and format envs, silencing the modern ruff deprecation warning.
77%
#131 chore(deps): update dependency lint/ruff to v0.0.291 starbase merged Renovate dependency bump of lint/ruff from v0.0.290 to v0.0.291 in .pre-commit-config.yaml was approved and merged into main as commit c3c3313.
77%
#1346 chore(deps): update dependency ruff to v0.1.1 charmcraft closed Renovate's ruff 0.0.282->0.1.1 bump PR was closed unmerged by lengau as superseded by #1347, which updated the ruff pre-commit hook and auto-fixed new lint errors (merged 2023-10-23, commit 34018724).
76%
#36 chore: switch to ruff craft-platforms merged Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files.
75%
#38 chore: update pre-commit hooks craft-platforms merged Merged PR #38 updated the pre-commit hooks configuration (+3/-3) and landed as commit 9a58c7f.
74%