← Back to issue list

chore: use the non-legacy ruff check pre-commit hook

View original Github issue

Metadata

Project
starbase
Number
#562
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged to replace the deprecated ruff pre-commit hook with the non-legacy ruff-check hook. Approved by two reviewers, passed all CI checks, and committed with a single line change.

Suggested action:

No scores available.

Issue body

The `ruff` pre-commit hook is a legacy one replaced with `ruff-check`. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to replace the deprecated ruff pre-commit hook with the non-legacy ruff-check hook. Approved by two reviewers, passed all CI checks, and committed with a single line change.
qwen3.6-35b-a3b-mtp-q6 Merged the update to replace the legacy ruff pre-commit hook with the non-legacy ruff-check hook, updating the project linting configuration to use the current recommended tool.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#380 chore: update ruff pre-commit away from legacy craft-store merged Merged a minimal update replacing the legacy ruff pre-commit hook with the new ruff-check variant. Approved by reviewers and passing CI checks, the change successfully modernizes the project's linting configuration.
90%
#1683 chore: explicitly use the 'check' command to avoid ruff warning about it charmcraft merged Merged an external contribution updating templates to explicitly use the ruff check command. This aligns with modern ruff syntax, eliminating deprecation warnings. Approved by two reviewers and passed CI checks.
80%
#700 chore: update ruff craft-parts merged Merged after approval by two reviewers and passing CI checks. Updates ruff configuration across four files, supersedes #699, and resolves a lint issue addressed in #702.
77%
#204 chore: use ruff snap starbase merged Merged "chore: use ruff snap". Approved by 3 reviewers and passed CI checks. Modified 4 files with a net diff of +5/-5 lines.
75%
#192 chore: update ruff settings starbase merged Merged updates to ruff configuration settings across two files. Approved by one reviewer, passed CI checks, and integrated into the main branch.
75%
#200 chore(deps): update ruff and its configuration craft-application merged Merged an update to ruff and its configuration. Approved by two reviewers with passing CI checks. The change modified one file with five additions and five deletions.
74%
#1347 chore(deps): update ruff and fix new linting errors charmcraft merged Merged after updating the ruff dependency and fixing new linting errors. Modifications were largely autoformatted across ten files. The changes received dual reviewer approval, passed CI checks, and were successfully integrated.
74%
#103 chore: fix new lints from ruff 0.12 craft-grammar merged Merged after approval and passing CI checks. Updated pre-commit ruff to 0.12 and resolved newly introduced lint errors across four files. Changes were cherry-picked from canonical/starbase#409.
73%
#146 chore(deps): include ruff in dev updates starbase merged Merged into main after approval and passing CI. The update incorporates the ruff linter into development dependencies following its 0.1 release, changing one file with no effect on test coverage.
73%
#4417 chore(deps): update ruff to 0.1.1 and fix lint issues snapcraft merged Merged dependency update upgrading ruff to 0.1.1 and resolving linting errors across 19 files. Approved by two reviewers, passed CI, and increased coverage by 0.01%. A newer ruff version was released shortly after merge.
73%