## 🤖 [BEEP BOOP, A BOT WROTE THIS DESCRIPTION - Step 5, opencode] Preparation PR for the Starbase sync in #440. Fixes the lint findings that `make lint` currently reports, so that the `lint / files` CI job passes. ### Why this is separate from #440 The Starbase merge in #440 adopts Starbase's expanded `tool.ruff.lint.select`, which adds `ASYNC`, `S*`, `FBT`, `COM`, `PIE*`, `SLF`, `TID`, `TC001`–`TC003`, `FIX`, `FLY`, `PERF`, `B035`, `RUF001`–`RUF013`, `RUF100` and `RUF200`. Several of those findings **already fire on `main` today** (`ICN001` is in `main`'s current `select`), and the rest surface once the merge lands. Per the preparation-PR rules these fixes belong in their own PR rather than bundled into the merge, so they can be reviewed and reverted independently. #440 stays in draft until this PR is merged. ### What's in it **Source fixes** | Finding | Where | Fix | |---|---|---| | `ICN001` (11) | 14 files in `craft_store/` and `tests/` | Adopt the `import datetime as dt` alias convention | | `TC002` | `craft_store/errors.py` | Move `requests` into a `TYPE_CHECKING` block | | `TC003` (2) | `craft_store/publisher/_publishergw.py` | Move `Collection`/`Sequence` into a `TYPE_CHECKING` block | | `PERF401` | `craft_store/errors.py` | List comprehension in `StoreErrorList.__str__` | | `RUF100` | `craft_store/creds.py` | Remove a stale `# noqa: ANN401` | | `ty` (2) | `tests/integration/test_upload.py`, `tests/unit/models/test_track_guardrail_model.py` | Pass model fields by their Python names instead of hyphenated alias dicts | The `TYPE_CHECKING` moves are safe: both modules already use `from __future__ import annotations` and the moved imports are used in annotations only. All modules still import cleanly. The `ty` fixes are behaviour-identical — `MarshableModel` sets `populate_by_name = True` (`craft_store/models/_base_model.py:28-33`), so `upload_id=` and `created_at=` resolve to the same fields as the alias dicts they replace. **Config additions** — new entries in `tool.ruff.lint.ignore` (child-owned values, per the ownership map): - `ANN401` — `Any` is used deliberately for forwarded keyword arguments (e.g. the `**kwargs` in `Credentials.model_validate_json`, which forwards to pydantic). - `FBT001`, `FBT002` — boolean positional arguments are part of this library's **public API** (`Auth.__init__`, `Auth.set_credentials`, `PublisherGateway.list_registered_names`). Making them keyword-only would break downstream craft apps, and backward compatibility is a hard requirement for this repository. - `FIX002` — TODOs in this repository are tracked outside the repo, not as issues. - `SLF001` — `httpbakery._interactor` has no public alternative; this code is pending migration to macaroonbakery (see the `TODO` in `store_client.py`). ### Validation | Check | Result | |---|---| | `ruff check craft_store tests` | **PASS** | | `ruff format --check craft_store tests` | **PASS** | | `ty check craft_store tests` | **PASS** | | `make test-fast` | **PASS** — 266 passed | Also verified clean against the merged `tool.ruff` config from #440, so nothing regresses once the merge lands. ### Note `make docs` fails identically on `main` with `find: '../.venv/lib/python*/site-packages/vale/vale_bin': No such file or directory`. This is pre-existing and environmental, not addressed here.