← Back to issue list

Move more linting to ruff

View original Github issue

Metadata

Project
snapcraft
Number
#4712
Type
issue
State
closed
Author
lengau
Labels
good first issue Status: Triaged Type: Enhancement
Created
Updated
Closed

Current evaluation

Completed. Linting configuration was updated to align with starbase, replacing isort with ruff and disabling redundant flake8 and pylint tests. Maintainer confirmed the changes and closed the issue.

Suggested action:

No scores available.

Issue body

### What needs to get done 1. Bring the latest linting config from starbase as much as possible 2. Replace isort with relevant ruff config. (Any unimplemented config is okay to ignore as long as ruff doesn't rewrite unchanged files) 3. Disable flake8 and pylint tests that are repeated by ruff ### Why it needs to get done Continuous improvement on the code quality front

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Completed. Linting configuration was updated to align with starbase, replacing isort with ruff and disabling redundant flake8 and pylint tests. Maintainer confirmed the changes and closed the issue.
qwen/qwen3.6-35b-a3b Completed. Linting was migrated to ruff, isort was replaced, and redundant flake8 and pylint tests were disabled. Snapcraft is now aligned with the starbase linting configuration.
qwen/qwen3.6-35b-a3b Completed. Linting was migrated to ruff, replacing isort and disabling redundant flake8 and pylint checks. The maintainer confirmed the project is now fully aligned with the starbase linting configuration.
qwen3.6-35b-a3b-mtp-q6 Resolved. Linting configuration was updated to align with starbase, replacing isort with ruff and disabling redundant flake8 and pylint tests. Snapcraft is now up-to-date.
qwen3.6-35b-a3b-mtp-q6 Completed. Linting was migrated to ruff, replacing isort and disabling redundant flake8 and pylint tests. Snapcraft is now aligned with the starbase configuration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#68 lint: update ruff and fix linting craft-archives merged Merged into main following reviewer approval and passing CI. Updates ruff configuration and resolves linting issues across four files, maintaining 100% diff coverage with no overall coverage change.
78%
#33 lint: fix lint issues with newer ruff craft-archives merged Merged to resolve linting failures introduced by a newer ruff version. Changes fix style checks across three files. Review approved, CI passed, and coverage remained unchanged. Additional unit tests were deferred to a separate tracking ticket.
78%
#4981 style(lint): fix ruff 0.6 linting errors snapcraft merged Merged after receiving two approvals and passing CI checks. Resolves ruff 0.6 linting errors with a minimal one-file change.
77%
#337 Linters: migrate from flake8 to ruff craft-parts merged Merged after approval, migrating linters from flake8 to ruff. Ruff is now the default, with flake8 retained as an optional make target. 4 files changed.
77%
#319 style: update linting configuration for ruff 0.9 starbase merged Merged update to linting configuration for ruff 0.9. Approved by one reviewer and passed CI. The minimal two-file change was accepted after the author deferred an unrelated git_describe_command suggestion to a separate PR.
77%
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged after approval by three reviewers. Resolves linting errors from a ruff update, modifying three files with a +7/-7 line change. Successfully integrated into the codebase.
76%
#408 style: fix linting for ruff 0.12 starbase merged Merged a one-line update to resolve linting errors for ruff 0.12. Approved by two reviewers and passed all CI checks before integration.
76%
#55 lint: stricter ruff rules starbase merged Merged stricter ruff linting rules. The change modifies one file with 23 additions and 9 deletions, enforces stricter configuration, and received reviewer approval before integration.
76%
#2074 style: update to ruff 0.9.0 formatting charmcraft merged Merged to align code formatting with ruff 0.9.0 linting rules. Approved by two reviewers and passed CI. One change was noted for upstreaming to starbase instead of applying it locally.
76%
#357 style: fix lints from ruff 0.12 craft-cli merged Merged following approval from three reviewers and successful CI checks. Resolved lint errors introduced by Ruff 0.12 across seven files with minor code adjustments.
75%