style: fix ruff and ty lint errors
Metadata
Current evaluation
Merged PR #1228 fixing ruff and ty lint errors, including datetime import aliasing, shadowed imports, invalid ClassVar overrides, and deprecated contextmanager annotations.
Resolution: closed resolved
Reason: The pull request was merged, resolving lint and type-checking failures across 9 files.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes lint failures from ruff and ty.
- `10b381e style: enforce datetime import aliasing and formatting per ruff` — alias `datetime` imports as `dt` (ICN001) and apply `ruff format`.
- `f79b63e style: resolve ty type-checking errors` — fix shadowed `datetime` import in `cli.py`, invalid mutable `ClassVar` override of `ARTIFACT` in recipe models, and deprecated `contextmanager` return annotation in conftest.
Verification: `make lint` and `make test-fast` pass.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | closed resolved | Merged PR #1228 fixing ruff and ty lint errors, including datetime import aliasing, shadowed imports, invalid ClassVar overrides, and deprecated contextmanager annotations. |
Update history
| Date | Change |
|---|---|
| merged | |
| updated | |
| updated | |
| updated | |
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #146 style: fix linting errors for ruff 0.12 | craft-platforms | merged | PR #146 merged in craft-platforms (commit fdad4a1) to fix ruff 0.12 lint errors: added # noqa: PLC0415 to lazy import in tests/conftest.py and ignored PLW1641 (eq-without-hash) in pyproject.toml. | |
| #242 style: fix ty linting error | craft-platforms | merged | Merged PR #242 with a one-line fix for the ty linting error; the change landed as commit e8b89ce. | |
| #19 style: fix linting issues for ruff 0.12 | craft-artifacts | closed | PR #19 was closed unmerged after prolonged inactivity; its Ruff 0.12 lint fixes were abandoned. Later PR #20 was merged as commit 04cbdc0. | |
| #1396 style: fix findings from ruff 0.17, shfmt, and tombi | rockcraft | merged | Merged PR fixing linting and style findings from ruff 0.17, shfmt, and tombi, plus adding ty diagnostic suppressions for intentional pydantic field narrowing. | |
| #20 style: fix ruff issue | craft-platforms | merged | Merged PR #20 fixed a Ruff linting issue in one file (+1/-3); resolution is commit 71a165d. | |
| #1737 style: fix linting for ruff 0.5 | charmcraft | merged | Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5. | |
| #441 fix: resolve ruff and ty lint findings | craft-store | closed | Merged to fix ruff and ty lint findings (import ordering, type-checking imports, ty model fields) in preparation for the Starbase sync PR #440. | |
| #1825 style(lint): fix ruff 0.6.0 linting errors | charmcraft | merged | Merged PR #1825 as commit 7aa2965b, applying Ruff 0.6.0 autofixes across 31 files to resolve linting errors. | |
| #4981 style(lint): fix ruff 0.6 linting errors | snapcraft | merged | Merged PR #4981 as commit 3a1b8a949, fixing Ruff 0.6 lint errors with a minimal one-file change. | |
| #173 style: fix lint for ruff 0.12 | craft-archives | merged | Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed. |