← Back to issue list

Refactor inspection and implement request and response methods

View original Github issue

Metadata

Project
fetch-service
Number
#15
Type
issue
State
closed
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Split into merged PRs #26, #28 and #41: opinion-based response validation, explicit request approval and request opinions superseded the broad refactor.

Resolution: closed superseded

Reason: The planned refactor was replaced by three focused changes. PR #26 (b0e6cac), PR #28 (7f8029b), and PR #41 (f687096) were merged to implement opinion-based artefact validation and request inspection behavior.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Request and response inspections were introduced in the latest Fetch Service design iteration, along with the concept of Opinions. Implement these new elements to obtain further insight on operational behavior. Refactoring the existing codebase may be required to accomodate the new features, but this shouldn't add too much complexity). ![image](https://github.com/canonical/fetch-service/assets/317355/30a39626-f264-4b3c-a57e-69b3a0a70556) ### Why it needs to get done Download authorization should also take request and response elements into consideration and deny access before actual payload data is transferred to the build environment. This inspection can also check the internal inspector state to verify requests and responses in context (e.g. checking if prerequisite data has been previously downloaded).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Split into merged PRs #26, #28 and #41: opinion-based response validation, explicit request approval and request opinions superseded the broad refactor.
qwen/qwen3.6-35b-a3b — closed superseded Superseded by PRs #41, #28, and #26, which implemented request opinions and inspection approval.

Update history

Date Change
created

Related work

  • Superseded By: canonical/fetch-service#26 (confidence 98%)

    Merged commit b0e6cac introduced opinion-based artefact validation.

  • Superseded By: canonical/fetch-service#28 (confidence 98%)

    Merged commit 7f8029b made request inspection approval explicit and consistent.

  • Superseded By: canonical/fetch-service#41 (confidence 98%)

    Merged commit f687096 added inspector request opinions and pending verification.

Related issues

Issue Project State Summary Similarity
#531 refactor: check if request opinion pending fetch-service merged Merged PR #531 refactored the request-opinion pending check in commit 3039a42 after two approvals and with all CI checks passing.
73%