← Back to issue list

feat: add sourcecraft inspector

View original Github issue

Metadata

Project
fetch-service
Number
#217
Type
pull request
State
merged
Author
dariuszd21
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #217 as commit 4e14f93, adding Sourcecraft inspection and repository-cloning support; it declared #211 fixed and followed prerequisite PR #216.

Resolution: closed resolved

Reason: PR #217 was merged after approval by two reviewers. Commit 4e14f93 added the Sourcecraft inspector and included changes intended to resolve #211.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? Fixes cloning repositories with fetch-service working and adds sourcecraft inspector. Should be merged after #216 Fixes: #211 (CRAFT-3336)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #217 as commit 4e14f93, adding Sourcecraft inspection and repository-cloning support; it declared #211 fixed and followed prerequisite PR #216.
stealth/space-bunny-alpha — closed resolved Merged in fetch-service#217 via 4e14f93, adding the Sourcecraft inspector and fixing repository cloning when fetch-service is active; resolved #211.
qwen/qwen3.6-35b-a3b — — Merged after two approvals. Introduces the sourcecraft inspector and resolves repository cloning issues with the fetch-service. Closes #211 and was integrated following #216.

Update history

Date Change
created

Related work

  • Related To: fetch-service#216 (confidence 100%)

    PR #216 was a required prerequisite and was merged first.

  • Related To: fetch-service#290 (confidence 95%)

    Commit 2ca0dfe in PR #290 later fixed #211 by changing Git repositories to be unpacked only once.

  • Likely Fixed By: fetch-service#211 (confidence 90%)

    PR #217 explicitly declares that it fixes #211, although the later PR #290 ultimately received credit for the cloning fix.

Related issues

Issue Project State Summary Similarity
#219 docs: document sourcecraft inspector fetch-service merged Merged PR #219 (commit f4a5dac) by dariuszd21 added docs/reference/sourcecraft.rst documenting the Sourcecraft inspector added in #217, closing CRAFT-3337. File later revised by #604.
79%
#222 test: enable sourcecraft inspector tests fetch-service merged Merged PR #222 as commit 6e68dc0, re-enabling Sourcecraft inspector tests accidentally disabled during refactoring; DEB tests were deferred to separate work.
76%
#624 feat: add bincraft inspector fetch-service closed PR #624 (bincraft inspector) closed unmerged after 92 days with failing cla-check and 3 unresolved review comments. Feature re-submitted as #626, merged as commit 6973fa9 and shipped in 0.17.0.
72%
#626 feat: bincraft inspector fetch-service merged Merged #626 as commit 6973fa9, adding the Bincraft inspector, adapted tests, and a .raw fixture-generation script; released in 0.17.0.
70%
#228 Sourcecraft inspector is too restrictive fetch-service closed Fixed by merged PR #229 (commit aaa40a4): Sourcecraft no longer inspects HTML responses, preventing unrelated permissive-mode artifacts from being rejected.
70%