← Back to issue list

feat: add 'macaroon' secret type

View original Github issue

Metadata

Project
fetch-service
Number
#532
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged addition of a 'macaroon' secret type to align with Store implementation. Requires base64-encoded input. Approved by two reviewers, passed CI checks, and merged despite one failing test. Modified 11 files.

Suggested action:

No scores available.

Issue body

This matches the macaroon implementation supported by the Store. Since the macaroon itself is a rather opaque sequence of bytes, the secret must be provided in the proper format for the wire, which is typically base64-encoded. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged addition of a 'macaroon' secret type to align with Store implementation. Requires base64-encoded input. Approved by two reviewers, passed CI checks, and merged despite one failing test. Modified 11 files.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#1765 store: refactor acquirement of attenuated macaroon snapcraft merged Merged after refactoring attenuated macaroon acquisition in the store module. Resolves issue #1709, enabling broader macaroon usage beyond Travis CI. Approved by one reviewer, passed CI, and modified eight files.
72%
#483 feat(secrets): support for 'basic' secrets fetch-service merged Merged feature adding support for basic secrets. Approved by three reviewers, passed all CI checks, and modified 14 files with 240 additions and 14 deletions.
71%