← Back to issue list

test(inspectors/snap): remove names API verification

View original Github issue

Metadata

Project
fetch-service
Number
#583
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #583 as 47d8d04, removing the daemon-state-dependent snap names API verification to fix flaky test issue #533.

Resolution: closed resolved

Reason: PR #583 was approved and merged as commit 47d8d04. Its two-line deletion removes the unreliable names API request check and explicitly fixes #533.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Don't check store API requests that depend on the internal state of the snap daemon and may or may not be present session report. Fixes #533 - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #583 as 47d8d04, removing the daemon-state-dependent snap names API verification to fix flaky test issue #533.
stealth/space-bunny-alpha — closed resolved Merged PR #583 as 47d8d04, removing the flaky snap inspector names API verification and fixing #533.
qwen/qwen3.6-35b-a3b — — Merged removal of names API verification from snap inspector tests, resolving #533. The change eliminates checks for store API requests dependent on internal snap daemon state, streamlining session report validation. Approved by two reviewers with passing CI.

Update history

Date Change
created

Related work

  • Related To: fetch-service#533 (confidence 100%)

    The flaky snap inspector spread test fixed by merged PR #583.

  • Related To: fetch-service#534 (confidence 90%)

    Earlier workaround merged as 4f89bb7 for the same snap test flakiness.

Related issues

Issue Project State Summary Similarity
#2351 tests: use valid snap names in unit tests snapcraft closed Closed unmerged; the same test-only change was merged instead via PR #2352 (commit b8c0a4fbf), updating unit-test snap names to pass `snap pack --check-skeleton`.
72%
#2352 tests: use valid snap names in unit tests snapcraft merged Merged PR #2352 (commit b8c0a4fbf) changed snap names used in unit tests so they pass snap pack --check-skeleton; author merged directly as a minor test-only change.
72%
#513 Add snaps/name inspector fetch-service closed Added the Snapcraft snap names inspector in merged PR #517 (commit 85f220e), resolving the LP test-build rejection.
70%