tests: use valid snap names in unit tests
Metadata
Current evaluation
Merged updates to unit tests that replace invalid snap names with valid ones, ensuring compatibility with snap pack --check-skeleton. The author approved and merged the minor change directly without external review.
Suggested action: —
No scores available.
Issue body
Use snap names that would pass a snap pack --check-skeleton run.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to unit tests that replace invalid snap names with valid ones, ensuring compatibility with snap pack --check-skeleton. The author approved and merged the minor change directly without external review. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by the author without review. Updated unit tests to use valid snap names compatible with snap pack --check-skeleton, ensuring compliance with packaging validation rules. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by the maintainer without review. Updated unit tests to use valid snap names that pass snap pack --check-skeleton validation. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2351 tests: use valid snap names in unit tests | snapcraft | closed | Closed without merging. The pull request updated unit tests to use valid snap names for snap pack --check-skeleton. Lacking reviews and CI checks, it was abandoned. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged tests for missing snap scenarios. Approved by two reviewers and integrated into the codebase despite unresolved review comments and reported integration test timeouts. | |
| #4755 tests: fix devel base snap test | snapcraft | merged | Merged a fix for the devel base snap test. The update ensures snapcraft correctly creates and utilizes the devel base. Approved by two reviewers, passed CI checks, and applied with a minimal one-file change. | |
| #1797 tests: update the snap name already registered for store tests | snapcraft | merged | Merged test update replacing a revoked snap name with an active one to match current store responses. Transient CI timeouts were retried before final merge. | |
| #1799 tests: update the registered snap fake | snapcraft | merged | Merged following approval by one reviewer. Updated the registered snap fake in tests, changing 2 files with 4 additions and 4 deletions. | |
| #2014 integration tests: snap tests shouldn't be arch-specific | snapcraft | merged | Merged a change removing architecture-specific constraints from snap integration tests. Approved by one reviewer with a two-line modification across a single file. | |
| #583 test(inspectors/snap): remove names API verification | fetch-service | merged | Merged removal of names API verification from snap inspector tests, resolving #533. The change eliminates checks for store API requests dependent on internal snap daemon state, streamlining session report validation. Approved by two reviewers with passing CI. | |
| #2421 tests: remove obsolete snap and external tests | snapcraft | merged | Merged after maintainer approval, removing obsolete snap and external tests. Accepted despite minor coverage drop and unrelated CI failures, though later noted to break documentation. | |
| #521 test(spread): add an improved snap inspector test | fetch-service | merged | Merged an improved snap inspector test that emulates system setup by stopping snapd, clearing device files, setting a global proxy, and restarting snapd to uncover network requests. Approved by two reviewers, passed all CI checks, and merged. | |
| #564 fix(test): remove env var set by snapped testing programs | craft-application | merged | Merged a fix for test failures caused by the SNAP_INSTANCE_NAME environment variable during snapped execution. The change removes it before tests to ensure consistent behavior. Approved by two reviewers and passed CI checks. |