tests: use valid snap names in unit tests
Metadata
Current evaluation
Merged PR #2352 (commit b8c0a4fbf) changed snap names used in unit tests so they pass snap pack --check-skeleton; author merged directly as a minor test-only change.
Resolution: closed resolved
Reason: The PR itself was merged into master as commit b8c0a4fbf, updating 24 test lines across 2 files to use valid snap names; the author commented it was merged without review as a minor change.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Use snap names that would pass a snap pack --check-skeleton run.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2352 (commit b8c0a4fbf) changed snap names used in unit tests so they pass snap pack --check-skeleton; author merged directly as a minor test-only change. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #2352 (commit b8c0a4fbf) merged into snapcraft, changing 2 test files (+24/-24) so unit tests use snap names that would pass snap pack --check-skeleton; author merged without review as trivial. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2352 updated unit-test snap names to pass snap pack --check-skeleton; the author merged it directly as a minor change. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to unit tests that replace invalid snap names with valid ones, ensuring compatibility with snap pack --check-skeleton. The author approved and merged the minor change directly without external review. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by the author without review. Updated unit tests to use valid snap names compatible with snap pack --check-skeleton, ensuring compliance with packaging validation rules. |
Update history
No update history recorded yet.
Related work
-
Duplicate Of:
canonical/snapcraft#2351
(confidence 71%)
Identical earlier attempt closed unmerged; same change landed via #2352 / b8c0a4fbf
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2351 tests: use valid snap names in unit tests | snapcraft | closed | Closed unmerged; the same test-only change was merged instead via PR #2352 (commit b8c0a4fbf), updating unit-test snap names to pass `snap pack --check-skeleton`. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e. | |
| #1068 tests: use a temporary directory for snaps tests | snapcraft | merged | Merged PR #1068 made snaps tests use a temporary directory, fixing Launchpad bug #1643658; landed as commit 1d4e5878d. | |
| #1187 tests: take into account the new current link. | snapcraft | merged | Merged in PR #1187 (commit 57055d1e4), updating tests to account for snapd's new ~/snap/<name>/current symlink. | |
| #583 test(inspectors/snap): remove names API verification | fetch-service | merged | Merged PR #583 as 47d8d04, removing the daemon-state-dependent snap names API verification to fix flaky test issue #533. | |
| #521 test(spread): add an improved snap inspector test | fetch-service | merged | Merged in PR #521 (commit 06cd210), adding a more realistic snapd setup to the spread snap inspector test and exposing additional snapd network requests. | |
| #1652 tests: fork skip into snaps_tests | snapcraft | merged | PR #1652 (merged as commit c951a3679) forked a skipped test into snaps_tests to avoid overly broad snapcraft.tests imports that broke autopackage tests. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged PR #3609 in commit a71aeff54, moving snapcraft_legacy unit tests from tests/unit to tests/legacy to match the package rename. | |
| #1797 tests: update the snap name already registered for store tests | snapcraft | merged | Updated store tests to use a currently registered, non-revoked snap after the previous test name was revoked; merged as commit 4cf4f33a. | |
| #1569 tests: refactor the fake snapd to not hardcode values | snapcraft | merged | Merged PR #1569 as commit cf2a0bf0a, refactoring fake snapd tests to remove hardcoded values; it was a required follow-up to #1567. |