tests: use valid snap names in unit tests
Metadata
Current evaluation
Closed without merging. The pull request updated unit tests to use valid snap names for snap pack --check-skeleton. Lacking reviews and CI checks, it was abandoned.
Suggested action: —
No scores available.
Issue body
Use snap names that would pass a snap pack --check-skeleton run.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The pull request updated unit tests to use valid snap names for snap pack --check-skeleton. Lacking reviews and CI checks, it was abandoned. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed to update unit tests with valid snap names that pass snap pack --check-skeleton. Codecov flagged missing base commit coverage, but the change was accepted without further discussion. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to update unit tests with valid snap names for snap pack validation. The change ensures test data passes skeleton checks, resolving test validation requirements. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2352 tests: use valid snap names in unit tests | snapcraft | merged | Merged updates to unit tests that replace invalid snap names with valid ones, ensuring compatibility with snap pack --check-skeleton. The author approved and merged the minor change directly without external review. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged tests for missing snap scenarios. Approved by two reviewers and integrated into the codebase despite unresolved review comments and reported integration test timeouts. | |
| #1790196 add tests for pushing with manifests | snapcraft (launchpad) | closed | Closed without discussion or comments. The request to add tests for pushing snaps with manifests was abandoned. | |
| #1008 docs: Add a space | rockcraft | closed | Closed and abandoned as a test contribution. The pull request failed CI checks for snap-tests, lint, and conventional commits policy. No reviews were received, and the change was not merged. | |
| #2421 tests: remove obsolete snap and external tests | snapcraft | merged | Merged after maintainer approval, removing obsolete snap and external tests. Accepted despite minor coverage drop and unrelated CI failures, though later noted to break documentation. | |
| #759 tests: investigate issue | craft-application | closed | Closed without merging. No reviews or comments were received, and CI checks failed. The pull request was likely abandoned after two weeks of inactivity. | |
| #2770 ci: always discard spread workers in snap-store-tests | charmcraft | closed | Abandoned without merge. The change to add a cleanup step preventing CI VM leaks in snap-store-tests received no reviews and was closed. |