tests: use valid snap names in unit tests
Metadata
Current evaluation
Closed unmerged; the same test-only change was merged instead via PR #2352 (commit b8c0a4fbf), updating unit-test snap names to pass `snap pack --check-skeleton`.
Resolution: closed superseded
Reason: PR #2351 was closed without merging because an identical PR, #2352, was opened and merged to master as commit b8c0a4fbf ("tests: use valid snap names in unit tests (#2352)"), so the duplicate was abandoned.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Use snap names that would pass a snap pack --check-skeleton run.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; the same test-only change was merged instead via PR #2352 (commit b8c0a4fbf), updating unit-test snap names to pass `snap pack --check-skeleton`. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; the same change was merged via PR #2352 (commit b8c0a4fbf), making unit-test snap names valid for snap pack --check-skeleton. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The pull request updated unit tests to use valid snap names for snap pack --check-skeleton. Lacking reviews and CI checks, it was abandoned. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed to update unit tests with valid snap names that pass snap pack --check-skeleton. Codecov flagged missing base commit coverage, but the change was accepted without further discussion. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#2352
(confidence 95%)
Identical-titled PR that was actually merged, landing as commit b8c0a4fbf.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2352 tests: use valid snap names in unit tests | snapcraft | merged | Merged PR #2352 (commit b8c0a4fbf) changed snap names used in unit tests so they pass snap pack --check-skeleton; author merged directly as a minor test-only change. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e. | |
| #583 test(inspectors/snap): remove names API verification | fetch-service | merged | Merged PR #583 as 47d8d04, removing the daemon-state-dependent snap names API verification to fix flaky test issue #533. | |
| #1797 tests: update the snap name already registered for store tests | snapcraft | merged | Updated store tests to use a currently registered, non-revoked snap after the previous test name was revoked; merged as commit 4cf4f33a. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged PR #3609 in commit a71aeff54, moving snapcraft_legacy unit tests from tests/unit to tests/legacy to match the package rename. | |
| #1799 tests: update the registered snap fake | snapcraft | merged | Merged #1799, a test-only update to the registered snap fake changing four lines across two files; it received one approval with no unresolved comments. | |
| #1105 tests: rename the integration test snaps | snapcraft | merged | Renamed integration test snaps across 139 files; PR #1105 merged as commit 02de32a3, addressing Launchpad bug #1661893. | |
| #1877 tests: move test files out of the snapcraft dir | snapcraft | closed | Closed unmerged after conflicts; the test reorganization was redone and merged via snapcraft#1948 at commit 55ad11ccc, moving tests out of the snapcraft package. | |
| #1187 tests: take into account the new current link. | snapcraft | merged | Merged in PR #1187 (commit 57055d1e4), updating tests to account for snapd's new ~/snap/<name>/current symlink. | |
| #513 Add snaps/name inspector | fetch-service | closed | Added the Snapcraft snap names inspector in merged PR #517 (commit 85f220e), resolving the LP test-build rejection. |