← Back to issue list

style: remove pyright from pyproject

View original Github issue

Metadata

Project
imagecraft
Number
#231
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged #231 as 99ee57b, removing pyright from pyproject.toml so the Makefile-installed pyright snap takes priority.

Resolution: closed resolved

Reason: PR #231 merged with approval as commit 99ee57b. The change removes the Python pyright dependency and favors the snap-installed executable.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- Removes the pyright python dependency to give full priority to the pyright snap installed via the makefile.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #231 as 99ee57b, removing pyright from pyproject.toml so the Makefile-installed pyright snap takes priority.
stealth/space-bunny-alpha — closed resolved Merged PR #231 as commit 99ee57b, removing pyright from pyproject.toml so the Makefile-installed snap is preferred. Older-Ubuntu spread tests still failed.
qwen/qwen3.6-35b-a3b — — Merged. Removes the pyright Python dependency from pyproject.toml to prioritize the snap version installed via the makefile. Approved and merged despite failing spread tests on older Ubuntu releases.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of the pyright Python dependency from pyproject.toml to prioritize the pyright snap installed via the makefile. The change was integrated without comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#327 build(deps): remove pyright starbase merged Merged PR #327 removed pyright from build dependencies in commit 4c45c0e because it is installed separately via snap or uv.
76%
#46 lint: add pyright to setup.cfg craft-store closed PR #46 adding pyright to setup.cfg was closed unmerged: sergiusens replied the project already runs the faster Node-based pyright supplied as a snap, so the config change was unnecessary.
72%
#1298 build: remove pyright from dev dependencies craft-parts merged Merged PR #1298 (commit 89c6a6eb) dropped Pyright from craft-parts dev dependencies in 2 files (-25 lines), since Pyright is already installed as a snap and the PyPI dependency caused inconsistent CI environments.
72%
#179 build(deps): update dependency pyright to v1.1.403 imagecraft merged Renovate PR #179 merged into main as commit 6a19145, bumping pyright 1.1.402 -> 1.1.403 in pyproject.toml and the lockfile; approved with all relevant CI green. Pyright was later dropped from pyproject in #231.
72%