← Back to issue list

lint: add pyright to setup.cfg

View original Github issue

Metadata

Project
craft-store
Number
#46
Type
pull request
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

PR #46 adding pyright to setup.cfg was closed unmerged: sergiusens replied the project already runs the faster Node-based pyright supplied as a snap, so the config change was unnecessary.

Resolution: closed not a bug

Reason: The single-line setup.cfg change was declined and closed without merge; maintainer sergiusens commented "we are using pyright from node, which is provided as a snap :-) The node implementation is much faster", so no code landed. Pyright config was later handled elsewhere: commit 20eb129 (#170) added pyright as a dependency and 0b70cf1 (#299) uses existing/snap/uv pyright.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Add `pyright` to `setup.cfg`

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed not a bug PR #46 adding pyright to setup.cfg was closed unmerged: sergiusens replied the project already runs the faster Node-based pyright supplied as a snap, so the config change was unnecessary.
stealth/space-bunny-alpha — closed not a bug Closed unmerged: maintainers declined adding pyright to setup.cfg because the project already uses the faster Node-based Pyright supplied as a snap.
qwen/qwen3.6-35b-a3b — — Closed without merging. The maintainer declined the change because the project uses pyright from node via snap, which is faster. The request was rejected.

Update history

No update history recorded yet.

Related work

  • Related To: craft-store#170 (confidence 70%)

    Commit 20eb129 'build(deps): update pyright (#170)' later introduced pyright via pyproject/uv instead of setup.cfg, achieving the same goal a different way.

  • Related To: craft-store#299 (confidence 70%)

    Commit 0b70cf1 'feat: use existing, then snap, then uv pyright (#299)' implements exactly the snap-based pyright workflow sergiusens cited when declining this PR.

  • Related To: craft-store#421 (confidence 55%)

    Commit 2d1b165 'style: drop mypy, pyright (#421)' shows pyright was eventually removed again from the project tooling.

Related issues

Issue Project State Summary Similarity
#231 style: remove pyright from pyproject imagecraft merged Merged #231 as 99ee57b, removing pyright from pyproject.toml so the Makefile-installed pyright snap takes priority.
72%
#327 build(deps): remove pyright starbase merged Merged PR #327 removed pyright from build dependencies in commit 4c45c0e because it is installed separately via snap or uv.
70%