test(spread): switch to testing in destructive mode
Metadata
Current evaluation
Merged PR #302 as commit f6aae5e, switching spread tests to destructive mode while LXD lacks required loop-device support.
Resolution: closed resolved
Reason: The maintainer-authored PR was approved by two reviewers and merged as commit f6aae5e, updating six test files to use destructive spread mode.
Evaluated by: mr-cal-bot
No scores available.
Issue body
An upcoming change is going to to require access to losetup in all cases. This will make the LXD backend unusable for the timebeing while we can't use loop drives. Since not all spread backends support nested virtualization, we need to build in destructive mode for the timebeing.
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #302 as commit f6aae5e, switching spread tests to destructive mode while LXD lacks required loop-device support. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/imagecraft#302 (f6aae5e), switching spread tests to destructive mode to accommodate upcoming losetup access and temporarily avoid unsupported LXD loop drives. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #302 (commit f6aae5e), switching spread tests to destructive mode while losetup-dependent LXD support is unavailable. | |
| qwen/qwen3.6-35b-a3b | — | — | Switched spread tests to destructive mode and merged. This addresses an upcoming losetup requirement that temporarily breaks the LXD backend. Approved by two reviewers with passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a change to switch spread tests to destructive mode. This temporary workaround addresses an upcoming losetup requirement that disables the LXD backend and accommodates backends lacking nested virtualization. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2983 tests: add LXD spread test | snapcraft | merged | Merged PR #2983 as 4b8522a14, adding spread coverage that builds the LXD package with LXD and destructive/host providers; installation checks were deferred. | |
| #694 tests(spread): use LXD from `5.21/candidate` | rockcraft | merged | Merged PR #694 in commit 90bc9b34, pinning spread tests to LXD 5.21/candidate to restore main and strengthen LTS regression coverage. | |
| #467 test(spread): use LXD provider for spread tests | imagecraft | closed | PR closed without merge; spread LXD provider changes were implemented across follow-up PRs (#483, #485, #486, #487, #488, #495) | |
| #2631 spread tests: enable LXD build provider tests | snapcraft | merged | Merged PR #2631 enabled LXD build-provider spread tests and reused early-prepared LXD setup, reducing repeated setup and image-download overhead. | |
| #5856 fix(spread): pack with lxd for core20 base tests | snapcraft | merged | Merged PR #5856 (commit 66b9ae9f4) updated Spread core20-base tests to pack with LXD. | |
| #485 test(spread): test uc-prepare in lxd | imagecraft | merged | Merged PR adding spread tests for uc-prepare on LXD across core22, core24, and core26 base images. | |
| #1133 test(spread): make LXD refresh in prepare more reliable | craft-application | closed | Closed unmerged; its LXD auto-refresh race fix was superseded by merged PR #1170 (commit fea3e835), which waits for active snap refreshes during spread prepare. | |
| #1522 tests(spread): don't use microk8s for dependencies tests | charmcraft | merged | Merged PR #1522 as commit 17669e12, replacing MicroK8s with a localhost LXD controller for spread dependency tests. | |
| #2937 spread tests: do not attempt to remove snapd snap | snapcraft | merged | Merged in commit b9290bb32; spread tests now skip removing the protected snapd snap, fixing LXD test failures. | |
| #269 tests: add initial spread testing | fetch-service | merged | Merged PR #269 (commit 8fe0091) added initial Spread integration tests to fetch-service: spread.yaml plus snap-config, basic-inspection, update-config and upgrade-revert suites; all 10 lxd-vm tasks passed, resolving #226. |