spread tests: do not attempt to remove snapd snap
Metadata
Current evaluation
Merged a one-line fix to prevent spread tests from removing the snapd snap in LXD environments, resolving test failures caused by snapd's protected status. Approved by one reviewer with passing CI checks.
Suggested action: —
No scores available.
Issue body
Fixes spread test errors with LXD using snapd snap.
error: cannot remove "snapd": snap "snapd" is not removable:
remove all other snaps first
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a one-line fix to prevent spread tests from removing the snapd snap in LXD environments, resolving test failures caused by snapd's protected status. Approved by one reviewer with passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for spread test failures in LXD. The change prevents cleanup routines from attempting to remove the snapd snap, resolving errors caused by its immutability when other snaps are present. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for spread test failures in LXD. The change prevents test scripts from attempting to remove the snapd snap, resolving an error caused by snapd's dependency on other installed snaps. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5856 fix(spread): pack with lxd for core20 base tests | snapcraft | merged | Merged after two approvals. Updates spread tests to pack with LXD for core20 base tests. CI passed with one non-blocking schema diff failure. Related core20 and snapd test failures were resolved in separate PRs. | |
| #3120 spread: only run in LXD with the google/multipass provider for repo | snapcraft | merged | Merged changes restricting spread tests to LXD with the google/multipass provider for the repo. Switched autopkgtest to destructive mode to bypass dirmngr failures until the environment is verified. Approved and passed CI. | |
| #302 test(spread): switch to testing in destructive mode | imagecraft | merged | Switched spread tests to destructive mode and merged. This addresses an upcoming losetup requirement that temporarily breaks the LXD backend. Approved by two reviewers with passing CI checks. | |
| #521 test(spread): add an improved snap inspector test | fetch-service | merged | Merged an improved snap inspector test that emulates system setup by stopping snapd, clearing device files, setting a global proxy, and restarting snapd to uncover network requests. Approved by two reviewers, passed all CI checks, and merged. | |
| #2983 tests: add LXD spread test | snapcraft | merged | Merged after reviewer approval and passing CI checks. Added LXD spread test to verify LXD builds and installs. Modified two files with 29 added lines. | |
| #202 tests: bump lxd to 5.11 in spread tests | rockcraft | merged | Merged update bumping LXD in spread tests to 5.11, resolving installation failures from the unlisted 5.9 snap channel. Approved by two reviewers and passed CI. | |
| #240 tests: check for submodules before running spread | rockcraft | merged | Merged. Adds a pre-check for the snapd-testing-tools submodule before running spread tests, providing a clear error if missing. Approved by two reviewers, passed CI, and merged successfully. | |
| #3640 spread: update error when local snap is missing | snapcraft | merged | Merged a one-line change to improve error reporting when a local snap is missing during spread updates. Approved by a reviewer, passed CI, and integrated into the repository. | |
| #3957 tests: retry installing lxd snap | snapcraft | merged | Merged into main. Introduces retry logic for LXD snap installation in tests via snapd-testing-tools to workaround an intermittent snapd bug. Approved, passed CI, and caused no coverage changes. | |
| #3962 Setup snapd for snapcraft_legacy providers | snapcraft | merged | Merged a fix for failing spread tests caused by missing snapd sockets in LXD containers. The change adopts snapd initialization logic from craft-providers to properly start the service, resolving connection errors. Approved and passed CI. |