← Back to issue list

providers: support `rockcraft clean` for a rockcraft environment

View original Github issue

Metadata

Project
rockcraft
Number
#108
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/rockcraft#108 (6d6987cd), adding `rockcraft clean` support to delete the Rockcraft LXD instance through the provider Executor.

Resolution: closed resolved

Reason: PR #108 was merged as commit 6d6987cd, completing provider cleanup for the command introduced in #93 by deleting the Rockcraft LXD environment through the Executor.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Support the command `rockcraft clean` to clean a rockcraft environment (i.e. delete a LXD instance). I'm following the same implementation recently done in [snapcraft](https://github.com/snapcore/snapcraft/pull/3875) and [charmcraft](https://github.com/canonical/charmcraft/pull/835), where instances are deleted via the `Executor` object. (CRAFT-1373)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#108 (6d6987cd), adding `rockcraft clean` support to delete the Rockcraft LXD instance through the provider Executor.
stealth/space-bunny-alpha — closed resolved Merged PR #108 as commit 6d6987cd, adding `rockcraft clean` support to delete a Rockcraft LXD environment through the Executor.
stealth/space-bunny-alpha — closed resolved Merged support for rockcraft clean to delete a Rockcraft LXD environment via the Executor, following implementations in snapcraft#3875 and charmcraft#835 (CRAFT-1373).
qwen/qwen3.6-35b-a3b — — Merged implementation of rockcraft clean to delete LXD instances. Follows snapcraft and charmcraft patterns using the Executor object. Approved by reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged code adding rockcraft clean command to delete LXD instances. Implementation follows snapcraft and charmcraft patterns using the Executor object, resolving CRAFT-1373.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/rockcraft#93 (confidence 98%)

    Earlier merged PR added the clean command and provider-cleanup scaffolding.

  • Related To: snapcore/snapcraft#3875 (confidence 95%)

    Referenced as the implementation model for deleting instances via an Executor.

  • Related To: canonical/charmcraft#835 (confidence 95%)

    Referenced alongside Snapcraft as a prior Executor-based cleanup implementation.

Related issues

No related issues found above the similarity threshold.