← Back to issue list

providers: move lxd project name out of craft-providers interface

View original Github issue

Metadata

Project
rockcraft
Number
#110
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged refactoring that moves rockcraft's project name from lxd.py to providers.py in the craft-providers interface. Approved by one reviewer, passed CI, and successfully integrated.

Suggested action:

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- I promise this is my last `rockcraft` PR today :laughing: This PR pulls out rockcraft's project name out of `lxd.py` and moves it to `providers.py`.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged refactoring that moves rockcraft's project name from lxd.py to providers.py in the craft-providers interface. Approved by one reviewer, passed CI, and successfully integrated.
qwen3.6-35b-a3b-mtp-q6 Merged a refactoring change that relocated rockcraft's project name from lxd.py to providers.py, decoupling it from the craft-providers interface.
qwen3.6-35b-a3b-mtp-q6 Merged a refactor that moves rockcraft's project name from lxd.py to providers.py, decoupling it from the LXD provider implementation within the craft-providers interface.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3940 providers: move `get_provider()` to providers.py snapcraft merged Merged the refactoring that moves get_provider() to providers.py. Aligned with rockcraft, the change passed code review and CI checks, modified 7 files, and was successfully integrated into main.
77%
#9 providers: add build provider support (CRAFT-28) rockcraft merged Merged integration of rockcraft with craft-providers to run build providers on LXD instances. The change ports Charmcraft glue code, hardwires execution to LXD, and defers user messages and log retrieval to follow-up PRs. Approved and passed CI.
76%
#82 providers: move mount logic to lifecycle.py rockcraft merged Merged. Moved project directory mount logic from craft-providers to rockcraft's lifecycle.py, as it is rockcraft-specific. Approved, passed CI, and modified six files with a net reduction of 13 lines.
75%
#484 providers: refactor to better support multiple providers (CRAFT-362) charmcraft merged Merged following two approvals and passing CI. Refactored the providers module into a package introducing a common Provider interface and LXDProvider subclass to accommodate future providers like Multipass. No behavioral changes. Minor naming adjustments applied during review.
74%
#925 providers: set lxd project to 'charmcraft' charmcraft merged Merged a fix setting the LXD project to 'charmcraft' instead of 'default', resolving a regression from the craft-providers migration. Approved by one reviewer, the change updates two files with a +10/-4 diff.
74%
#74 providers: move get_instance_name() to providers.py rockcraft merged Merged after approval and passing CI. Moved the rockcraft-specific get_instance_name() function to providers.py, changing 8 files. Resolves CRAFT-1350.
74%
#3938 providers: move `confirm_with_user()` call to providers.py (#91) snapcraft merged Merged changes moving the snapcraft-specific confirm_with_user() call out of the craft-providers interface into providers.py. The update was approved, passed CI, and aligns with parallel rockcraft modifications.
73%
#80 providers: move `get_instance_name()` call to lifecycle.py rockcraft merged Merged. Moved the rockcraft-specific get_instance_name() call from provider classes to lifecycle.py to separate application-specific logic. Approved by reviewer, CI passed, spanning 6 files with 57 additions and 34 deletions.
72%
#91 providers: move `confirm_with_user()` call to providers.py rockcraft merged Merged after approval and passing CI. Moved the rockcraft-specific confirm_with_user logic out of the craft-providers interface into providers.py. Renamed is_provider_available to is_provider_installed across ten files.
72%
#27 fix: use lxd from "5.21/stable" craft-actions merged Merged a fix switching the LXD channel from latest/stable to 5.21/stable. This resolves Rockcraft overlay compatibility issues and aligns with the recommended LTS release. Approved by two reviewers with a three-file change.
71%