← Back to issue list

feat(extensions): add Go framework V2 extension and factory dispatch

View original Github issue

Metadata

Project
rockcraft
Number
#1251
Type
pull request
State
closed
Author
Thanhphan1147
Labels
—
Created
Updated
Closed

Current evaluation

GoFrameworkV2 and factory dispatch moved into canonical/rockcraft#1259, which merged as commit 644c6950; #1251 was closed as superseded.

Resolution: closed superseded

Reason: The author stated that the changes were merged into #1259 to reduce review overhead. That PR subsequently merged as commit 644c6950.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add GoFrameworkV2 (targets ubuntu@26.04, inherits GoFramework) and a GoFrameworkFactory that dispatch the V1 or V2 extension class depending on the base. Implements ISD283 (internal) for the go-framework extension. Describe your changes. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded GoFrameworkV2 and factory dispatch moved into canonical/rockcraft#1259, which merged as commit 644c6950; #1251 was closed as superseded.
stealth/space-bunny-alpha — closed superseded PR closed as superseded: its GoFrameworkV2 class and GoFrameworkFactory dispatch were folded into base PR #1259, merged as commit 644c6950 and present in rockcraft/extensions/go.py.
stealth/space-bunny-alpha — closed superseded PR closed unmerged: author redirected GoFrameworkV2 + GoFrameworkFactory dispatch into base PR #1259, which merged as commit 644c6950; code now present in rockcraft/extensions/go.py.
stealth/space-bunny-alpha — closed superseded Closed as superseded: GoFrameworkV2 and factory dispatch were folded into base PR #1259, which merged as commit 644c6950.
stealth/space-bunny-alpha — closed superseded Folded into Rockcraft PR #1259, which merged as 644c6950 with base-aware V2 framework dispatch, including the Go framework changes.
qwen/qwen3.6-35b-a3b — — Superseded. Changes merged into base PR #1259 to consolidate review. Closed without independent merging.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/rockcraft#1259 (confidence 100%)

    The closing comment names #1259 as the replacement; it merged as 644c6950.

Related issues

Issue Project State Summary Similarity
#1257 feat(extensions): add ExpressJS framework V2 extension and factory dispatch rockcraft closed ExpressJS V2 extension + factory dispatch were folded into base PR #1259, merged as commit 644c6950; this PR was closed as redundant.
72%
#1258 feat(extensions): add SpringBoot framework V2 extension and factory dispatch rockcraft closed PR closed unmerged: author moved the SpringBootFrameworkV2 + SpringBootFrameworkFactory dispatch changes into base PR #1259, which was merged in commit 644c6950 covering V2 dispatch for 12-factor extensions.
71%
#1259 feat(extensions): extension dispatch for 12-factor extensions. rockcraft merged Merged as commit 644c6950, adding _FrameworkFactory dispatch plus V2 extension classes (Flask, Django, FastAPI, ExpressJS, SpringBoot) targeting ubuntu@26.04; extended later by #1320/#1332/#1345/#1364.
71%
#1254 feat(extensions): add Flask framework V2 extension and factory dispatch rockcraft closed PR closed as redundant: the author moved the FlaskFrameworkV2 and FlaskFrameworkFactory changes into base PR #1259, which merged as commit 644c6950 ('feat(extensions): extension dispatch for 12-factor extensions'), covering all five framework V2 extensions.
70%