← Back to issue list

feat(extensions): add SpringBoot framework V2 extension and factory dispatch

View original Github issue

Metadata

Project
rockcraft
Number
#1258
Type
pull request
State
closed
Author
Thanhphan1147
Labels
—
Created
Updated
Closed

Current evaluation

PR closed unmerged: author moved the SpringBootFrameworkV2 + SpringBootFrameworkFactory dispatch changes into base PR #1259, which was merged in commit 644c6950 covering V2 dispatch for 12-factor extensions.

Resolution: closed superseded

Reason: The author commented that the changes were merged into base PR #1259 to reduce review overhead and asked that #1258 be closed; #1259 was subsequently merged as commit 644c6950, adding the SpringBoot V2 dispatch along with Flask, Django, FastAPI and ExpressJS.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add SpringBootFrameworkV2 (targets ubuntu@26.04, inherits SpringBootFramework) and a SpringBootFrameworkFactory that dispatch the V1 or V2 extension class depending on the base. Implements ISD283 (internal) for the spring-boot-framework extension. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR closed unmerged: author moved the SpringBootFrameworkV2 + SpringBootFrameworkFactory dispatch changes into base PR #1259, which was merged in commit 644c6950 covering V2 dispatch for 12-factor extensions.
stealth/space-bunny-alpha — closed superseded Spring Boot V2 factory dispatch was merged via #1259 in commit 644c6950, consolidating this PR's changes; the standalone PR was closed.
qwen/qwen3.6-35b-a3b — — Superseded by PR #1259. The SpringBoot framework V2 extension and factory dispatch implementation was merged into the base pull request to consolidate reviews. This pull request was closed.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/rockcraft#1259 (confidence 97%)

    Base PR that absorbed this change and was merged (commit 644c6950) with V2 dispatch for the 12-factor extensions.

Related issues

Issue Project State Summary Similarity
#1257 feat(extensions): add ExpressJS framework V2 extension and factory dispatch rockcraft closed ExpressJS V2 extension + factory dispatch were folded into base PR #1259, merged as commit 644c6950; this PR was closed as redundant.
80%
#1254 feat(extensions): add Flask framework V2 extension and factory dispatch rockcraft closed PR closed as redundant: the author moved the FlaskFrameworkV2 and FlaskFrameworkFactory changes into base PR #1259, which merged as commit 644c6950 ('feat(extensions): extension dispatch for 12-factor extensions'), covering all five framework V2 extensions.
79%
#1255 feat(extensions): add Django framework V2 extension and factory dispatch rockcraft closed PR closed as redundant: its Django V2 extension and factory dispatch changes were folded into base PR #1259, which merged to main as commit 644c6950 (feat(extensions): extension dispatch for 12-factor extensions).
79%
#1259 feat(extensions): extension dispatch for 12-factor extensions. rockcraft merged Merged as commit 644c6950, adding _FrameworkFactory dispatch plus V2 extension classes (Flask, Django, FastAPI, ExpressJS, SpringBoot) targeting ubuntu@26.04; extended later by #1320/#1332/#1345/#1364.
76%
#1256 feat(extensions): add FastAPI framework V2 extension and factory dispatch rockcraft closed FastAPI V2 and factory-dispatch work was folded into #1259 and merged as 644c6950; standalone PR #1256 was closed to reduce review overhead.
74%
#1251 feat(extensions): add Go framework V2 extension and factory dispatch rockcraft closed GoFrameworkV2 and factory dispatch moved into canonical/rockcraft#1259, which merged as commit 644c6950; #1251 was closed as superseded.
71%