← Back to issue list

feat(extensions): add ExpressJS framework V2 extension and factory dispatch

View original Github issue

Metadata

Project
rockcraft
Number
#1257
Type
pull request
State
closed
Author
Thanhphan1147
Labels
—
Created
Updated
Closed

Current evaluation

ExpressJS V2 extension + factory dispatch were folded into base PR #1259, merged as commit 644c6950; this PR was closed as redundant.

Resolution: closed superseded

Reason: The author noted on 2026-06-23 that these changes were merged into base PR #1259 to reduce review overhead and asked for this PR to be closed. #1259 merged as commit 644c6950, which added _FrameworkFactory dispatch and ExpressJSFrameworkV2 (now present in rockcraft/extensions/expressjs.py with ExpressJSFrameworkFactory at line 482).

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add ExpressJSFrameworkV2 (targets ubuntu@26.04, inherits ExpressJSFramework) and a ExpressJSFrameworkFactory that dispatch the V1 or V2 extension class depending on the base. Implements ISD283 (internal) for the expressjs-framework extension. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded ExpressJS V2 extension + factory dispatch were folded into base PR #1259, merged as commit 644c6950; this PR was closed as redundant.
stealth/space-bunny-alpha — closed superseded ExpressJS V2 and factory-dispatch changes were consolidated into PR #1259, merged as commit 644c6950; this PR was closed as superseded to reduce review overhead.
qwen/qwen3.6-35b-a3b — — Superseded and closed. The ExpressJS framework V2 extension and factory dispatch were merged into base pull request #1259 to consolidate reviews. Author requested closure of this branch.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/rockcraft#1259 (confidence 95%)

    Base PR that absorbed these changes; merged as commit 644c6950 and now contains ExpressJSFrameworkV2 and ExpressJSFrameworkFactory in rockcraft/extensions/expressjs.py.

Related issues

Issue Project State Summary Similarity
#1255 feat(extensions): add Django framework V2 extension and factory dispatch rockcraft closed PR closed as redundant: its Django V2 extension and factory dispatch changes were folded into base PR #1259, which merged to main as commit 644c6950 (feat(extensions): extension dispatch for 12-factor extensions).
80%
#1258 feat(extensions): add SpringBoot framework V2 extension and factory dispatch rockcraft closed PR closed unmerged: author moved the SpringBootFrameworkV2 + SpringBootFrameworkFactory dispatch changes into base PR #1259, which was merged in commit 644c6950 covering V2 dispatch for 12-factor extensions.
80%
#1254 feat(extensions): add Flask framework V2 extension and factory dispatch rockcraft closed PR closed as redundant: the author moved the FlaskFrameworkV2 and FlaskFrameworkFactory changes into base PR #1259, which merged as commit 644c6950 ('feat(extensions): extension dispatch for 12-factor extensions'), covering all five framework V2 extensions.
79%
#1256 feat(extensions): add FastAPI framework V2 extension and factory dispatch rockcraft closed FastAPI V2 and factory-dispatch work was folded into #1259 and merged as 644c6950; standalone PR #1256 was closed to reduce review overhead.
79%
#1259 feat(extensions): extension dispatch for 12-factor extensions. rockcraft merged Merged as commit 644c6950, adding _FrameworkFactory dispatch plus V2 extension classes (Flask, Django, FastAPI, ExpressJS, SpringBoot) targeting ubuntu@26.04; extended later by #1320/#1332/#1345/#1364.
74%
#1251 feat(extensions): add Go framework V2 extension and factory dispatch rockcraft closed GoFrameworkV2 and factory dispatch moved into canonical/rockcraft#1259, which merged as commit 644c6950; #1251 was closed as superseded.
72%
#2244 Feat/expressjs extension charmcraft merged ExpressJS framework support was merged via commit b50d41b9, adding the extension, init templates, documentation, and tests.
71%