← Back to issue list

project: make build-base optional, defaults to base (CRAFT-590)

View original Github issue

Metadata

Project
rockcraft
Number
#13
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged after review and CI checks, making the build-base attribute in rockcraft.yaml optional and defaulting to base when unspecified. Implementation spans three files with 42 additions and 8 deletions.

Suggested action:

No scores available.

Issue body

Change the `build-base` attribute to be optional in rockcraft.yaml. If not specified, default to the value set in `base`. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after review and CI checks, making the build-base attribute in rockcraft.yaml optional and defaulting to base when unspecified. Implementation spans three files with 42 additions and 8 deletions.
qwen3.6-35b-a3b-mtp-q6 Merged. Made the build-base attribute optional in rockcraft.yaml, defaulting to the base value when unspecified. Resolves CRAFT-590.
qwen3.6-35b-a3b-mtp-q6 Merged. Made the build-base attribute optional in rockcraft.yaml, defaulting to base when unspecified. Implemented by maintainer Claudio Matsuoka to resolve CRAFT-590.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#36 project: support build-base and allow 'bare' bases rockcraft merged Merged. Adds build-base property support to rockcraft.yaml, enabling bare bases and ubuntu:22.04. Resolved review comments, fixed a bare base bug, removed a mistaken diff change, and addressed documentation conflicts prior to merge.
84%
#8 project: add rockcraft.yaml load function (CRAFT-586) rockcraft merged Merged after approval and passing CI checks. Extracts project file loading into a dedicated function with tests, modifying four files with 89 additions and 19 deletions.
72%
#6 project: add basic rockcraft.yaml parsing and validation (CRAFT-584) rockcraft merged Merged changes adding rockcraft.yaml parsing and validation to halt builds on invalid parts. Renamed the tag field to version and updated the output image suffix to .rock. Approved and passed CI across seven files.
71%
#72 providers: deprecate RockcraftBuilddBaseConfiguration rockcraft merged Merged deprecation of RockcraftBuilddBaseConfiguration, replacing it with BuilddBase using a compatibility tag parameter. Removes the custom class with no functional impact. Approved and passed CI.
70%