providers: remove deprecated `build_base` parameter
Metadata
Current evaluation
Merged PR #4204 via commit d77b51446, removing the deprecated build_base argument from craft-providers launched_environment() calls.
Resolution: closed resolved
Reason: PR #4204 was approved and merged into main. Commit d77b51446 removes the deprecated parameter, aligning main with craft-providers 1.11.0+ while leaving the 1.10.0-dependent hotfix branch unchanged.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
The `build_base` parameter for craft-provider's `launched_environment()` was deprecated in craft-providers 1.11.0.
Targeting `main` because `hotfix/7.4` is still using craft-providers 1.10.0.
source: https://chat.charmhub.io/charmhub/pl/nrgr4q5e8tna8ggpwdu69wuhwh
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4204 via commit d77b51446, removing the deprecated build_base argument from craft-providers launched_environment() calls. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into main as commit d77b514: dropped the craft-providers `build_base` argument from `launched_environment()` calls in lifecycle.py and its tests, updating for craft-providers 1.11.0. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into main as d77b51466, removing the deprecated build_base parameter from craft-providers' launched_environment() and aligning usage with craft-providers 1.11.0+. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4204 into main, removing the deprecated build_base argument from craft-providers launched_environment() calls. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into main after approval and CI checks. Removes the deprecated build_base parameter from craft-provider's launched_environment method, aligning with craft-providers 1.11.0+. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to main, removing the deprecated build_base parameter from craft-provider's launched_environment() method. This update aligns with craft-providers 1.11.0 and drops legacy configuration. Code coverage remained unchanged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4505 chore: remove deprecated parameter `build-base` | snapcraft | merged | PR #4505 merged as 4aa5f63cb, dropping the deprecated build_base arg passed to craft-providers to silence its deprecation warning; the same cleanup had already landed on main via PR #4204 (d77b51466). | |
| #3934 providers: deprecate SnapcraftBuilddBaseConfiguration | snapcraft | merged | Merged PR #3934 (commit f6abc2efd), replacing the custom buildd configuration with craft-providers BuilddBase and moving compatibility-tag setup to its constructor. | |
| #72 providers: deprecate RockcraftBuilddBaseConfiguration | rockcraft | merged | Merged PR #72 in commit 7747a03d, replacing RockcraftBuilddBaseConfiguration with craft-providers BuilddBase and compatibility tags; no functional changes. | |
| #255 provider: deprecate build_base | craft-providers | merged | Merged PR #255 (2495ae8), shifting OS/version selection to base_configuration, adding alias helpers, and making build_base ineffective; the parameter was later removed in 2.0.0. | |
| #13 project: make build-base optional, defaults to base (CRAFT-590) | rockcraft | merged | Merged PR #13 via commit 7ac8e01e (merge ff694dcd), making build-base optional and defaulting it to base when omitted. | |
| #3202 build providers: fix base change warning message | snapcraft | merged | Merged PR #3202 as commit c4e3c0ccb, correcting the misleading build-provider warning emitted when a base changes. | |
| #2474 build providers: remove dead code | snapcraft | merged | Merged PR #2474 as commit 4308dd8d3, removing obsolete build-provider methods left over from legacy cleanbuild support. |