chore: remove deprecated parameter `build-base`
Metadata
Current evaluation
PR #4505 merged as 4aa5f63cb, dropping the deprecated build_base arg passed to craft-providers to silence its deprecation warning; the same cleanup had already landed on main via PR #4204 (d77b51466).
Resolution: closed resolved
Reason: The PR was approved and merged as commit 4aa5f63cb ("chore: remove deprecated parameter `build-base` (#4505)"), a 3-file, +1/-5 diff removing build_base from the craft-providers call. The author noted the identical fix was already on main via commit d77b51466 from PR #4204, and the only follow-up comment concerned an unrelated spread-test/node failure.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Stop passing the deprecated parameter `build_base` to craft-providers to avoid the warning intended for developers:
```
Deprecated: Parameter 'build_base' is deprecated and should not be used. The build base now comes from the base_configuration's alias.
```
Note this is already fixed on main.
Source: https://matrix.to/#/!GGqzbFAUQprdPgYYCM:ubuntu.com/$bxytvo9JAtlAkoLNJyXsaQ-4xUM0xRBMLxwP_f1jh34?via=ubuntu.com&via=matrix.org&via=xentonix.net
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #4505 merged as 4aa5f63cb, dropping the deprecated build_base arg passed to craft-providers to silence its deprecation warning; the same cleanup had already landed on main via PR #4204 (d77b51466). | |
| stealth/space-bunny-alpha | — | closed resolved | PR #4505 merged as 4aa5f63cb, removing deprecated build_base passed to craft-providers; the same cleanup had already landed on main in d77b51466. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4505 stopped passing deprecated build_base to craft-providers, removing the warning because the build base now comes from base_configuration's alias. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to remove the deprecated build-base parameter from craft-providers, eliminating a deprecation warning. Approved, passed CI and tests, and modified three files. The fix was already on the main branch. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to remove the deprecated build_base parameter and eliminate developer warnings. Approved by maintainer after passing tests and coverage. The change was already on main, suggesting a backport or duplicate cleanup. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcore/snapcraft#4204
(confidence 92%)
PR #4204 merged as d77b51466 ("providers: remove deprecated `build_base` parameter") already removed the parameter on main; #4505 applied the same removal to the release branch, per the author's 'already fixed on main' note.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4204 providers: remove deprecated `build_base` parameter | snapcraft | merged | Merged PR #4204 via commit d77b51446, removing the deprecated build_base argument from craft-providers launched_environment() calls. | |
| #13 project: make build-base optional, defaults to base (CRAFT-590) | rockcraft | merged | Merged PR #13 via commit 7ac8e01e (merge ff694dcd), making build-base optional and defaulting it to base when omitted. | |
| #255 provider: deprecate build_base | craft-providers | merged | Merged PR #255 (2495ae8), shifting OS/version selection to base_configuration, adding alias helpers, and making build_base ineffective; the parameter was later removed in 2.0.0. | |
| #3202 build providers: fix base change warning message | snapcraft | merged | Merged PR #3202 as commit c4e3c0ccb, correcting the misleading build-provider warning emitted when a base changes. | |
| #72 providers: deprecate RockcraftBuilddBaseConfiguration | rockcraft | merged | Merged PR #72 in commit 7747a03d, replacing RockcraftBuilddBaseConfiguration with craft-providers BuilddBase and compatibility tags; no functional changes. | |
| #3934 providers: deprecate SnapcraftBuilddBaseConfiguration | snapcraft | merged | Merged PR #3934 (commit f6abc2efd), replacing the custom buildd configuration with craft-providers BuilddBase and moving compatibility-tag setup to its constructor. |