chore: remove deprecated parameter `build-base`
Metadata
Current evaluation
Merged to remove the deprecated build-base parameter from craft-providers, eliminating a deprecation warning. Approved, passed CI and tests, and modified three files. The fix was already on the main branch.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Stop passing the deprecated parameter `build_base` to craft-providers to avoid the warning intended for developers:
```
Deprecated: Parameter 'build_base' is deprecated and should not be used. The build base now comes from the base_configuration's alias.
```
Note this is already fixed on main.
Source: https://matrix.to/#/!GGqzbFAUQprdPgYYCM:ubuntu.com/$bxytvo9JAtlAkoLNJyXsaQ-4xUM0xRBMLxwP_f1jh34?via=ubuntu.com&via=matrix.org&via=xentonix.net
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to remove the deprecated build-base parameter from craft-providers, eliminating a deprecation warning. Approved, passed CI and tests, and modified three files. The fix was already on the main branch. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to remove the deprecated build_base parameter and eliminate developer warnings. Approved by maintainer after passing tests and coverage. The change was already on main, suggesting a backport or duplicate cleanup. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of the deprecated build-base parameter to prevent developer warnings. Approved, passed tests, and aligns with an existing fix on the main branch. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4204 providers: remove deprecated `build_base` parameter | snapcraft | merged | Merged into main after approval and CI checks. Removes the deprecated build_base parameter from craft-provider's launched_environment method, aligning with craft-providers 1.11.0+. | |
| #3202 build providers: fix base change warning message | snapcraft | merged | Merged after approval and passing CI. The pull request fixes the base change warning message in build providers, updating one file with four additions and two deletions. | |
| #4663 fix: use "devel" bases on build plan | snapcraft | merged | Merged after approval and passing CI. Updates BuildInfos to use devel bases for craft-providers via a new get_effective_base parameter. Removed an obsolete get_build_plan method from Project. Squash-merged. | |
| #3934 providers: deprecate SnapcraftBuilddBaseConfiguration | snapcraft | merged | Merged. Deprecated SnapcraftBuilddBaseConfiguration, replacing it with BuilddBase from craft-providers. Compatibility tagging now uses the BuilddBase constructor. Approved by one reviewer and passed CI checks. | |
| #1281 build(deps): update craft-providers to 3.7.1 | rockcraft | merged | Merged update to craft-providers 3.7.1, resolving a stonking failure in build-base: devel and forwarding proxy environment variables to pro methods. Approved and passed CI. | |
| #1414 chore(deps): use craft-providers 1.19.3 | charmcraft | merged | Merged dependency update to craft-providers 1.19.3, resolving cache directory deletion issues. Approved by two reviewers, passed CI checks, and integrated without unresolved comments. |