test(spread): fix cross-test contamination
Metadata
Current evaluation
Merged fix for spread test cross-contamination. Resolved by copying a clean rockcraft.yaml template at test start to isolate variants. Approved by two reviewers and passed CI checks.
Suggested action: —
No scores available.
Issue body
Multiple spread variants use the same 'python-from-chisel-bare' directory, so start the test by copying over a clean rockcraft.yaml template.
---
- [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md).
- [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [ ] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for spread test cross-contamination. Resolved by copying a clean rockcraft.yaml template at test start to isolate variants. Approved by two reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
5
Complexity:
15
Confidence:
90
|
needs review | Fixes cross-test contamination in spread tests by copying a clean rockcraft.yaml template at test start. Currently awaiting CI and maintainer review. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #100 tests: print rockcraft log files on spread failure | rockcraft | merged | Merged: adds 11 lines to print rockcraft log files during spread test failures, improving debugging visibility. Approved by one reviewer and passed CI checks. | |
| #174 tests: check before handling rockcraft instances | rockcraft | merged | Merged a fix wrapping rockcraft LXC instance cleanup in an if condition to prevent errors when spread tests do not create instances. Approved by two reviewers, passed CI, and modified one file. | |
| #173 tests: check before handling rockcraft instances | rockcraft | closed | Merged after two approvals and passing CI. Updates spread test cleanup to conditionally stop and delete rockcraft lxc instances, preventing errors when tests do not create them. (+5/-2 lines) | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks. | |
| #519 spread: reorganize spread tests | rockcraft | merged | Merged via squash-merge. Reorganizes spread tests to optimize CI resource usage by consolidating most tests into a jammy-based rockcraft suite and adding a foreign suite for cross-system testing. Changes affect 73 files. | |
| #1325 test(spread): consolidate basic init/build tests | charmcraft | merged | Merged after approval by two reviewers. Consolidates basic init and build spread tests across four files, reducing 80 lines and adding 28. Resolves CRAFT-2127. | |
| #400 fix(docs): make sure we can build the example rockcraft.yaml | rockcraft | merged | Merged to resolve issue #399. Added a spread test validating the example rockcraft.yaml build process for documentation. Approved by three reviewers and passed all CI checks. | |
| #13 test(spread): add more spread tests | snapcraft-rocks | merged | Successfully merged spread tests covering architectures, chisel slices, craftctl, package-repositories, and patchelf. Approved by two reviewers across 15 files (+206/-5 lines). | |
| #1761 tests(spread): temporarily disable failing test | charmcraft | merged | Merged to temporarily disable a failing upload-resource test in the spread suite due to bug #1760. Approved by two reviewers, passed CI, and modified one file. | |
| #1290 test(spread): clean up store tests | charmcraft | merged | Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers. |