← Back to issue list

lint: add ignore for new pyright

View original Github issue

Metadata

Project
rockcraft
Number
#251
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged a one-file change adding a pyright ignore directive to suppress warnings about unknown xdg fields introduced in pyright 1.1.306. Approved by two reviewers and passed all CI checks.

Suggested action:

No scores available.

Issue body

pyright 1.1.306 has updated checking that complains about accesses to unknown fields in `xdg`. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a one-file change adding a pyright ignore directive to suppress warnings about unknown xdg fields introduced in pyright 1.1.306. Approved by two reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged a linting update adding a pyright ignore rule to suppress warnings about unknown field accesses in the xdg module, resolving compatibility with pyright 1.1.306.
qwen3.6-35b-a3b-mtp-q6 Merged an update adding a pyright ignore directive to suppress linting warnings for unknown field accesses in the xdg module, addressing compatibility with pyright 1.1.306.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#237 style: fix pyright config craft-cli merged Merged a two-line fix to the pyright configuration, correcting ignores to apply recursively. Approved by two reviewers, passed CI, and integrated.
80%
#701 build(deps): update pyright to 1.1.358 craft-parts merged Merged update to pyright version 1.1.358. Approved by two reviewers and passed CI. A lint issue was addressed separately in PR #702. The change modified three files with minimal adjustments.
74%
#58 lint: fix typing issues with updated pyright craft-archives merged Merged following reviewer approval and successful CI checks. Fixed typing errors introduced by an updated pyright version across seven files. Improved overall code coverage by 0.03%.
74%
#1703 build: update pyright to 1.1.366 charmcraft merged Merged update to pyright version 1.1.366. The change modified two files with a net reduction of five lines. Approved by one reviewer with no unresolved comments before integration.
74%
#4233 type: workaround for pyright bug snapcraft merged Merged a two-file change (+4/-3 lines) implementing a workaround for pyright bug #5394. Approved by one reviewer, passed CI checks, and successfully integrated into the codebase.
73%
#102 test(lint): make pyright ignore _version.py craft-store merged Merged after approval and passing CI checks. The change adds a pyright ignore directive to suppress linting warnings for the _version.py file, resolving a test/lint issue with a single line addition.
73%
#342 type: fix pyright possibly-unbound error rockcraft merged Merged to resolve a pyright possibly-unbound type error. Approved by two reviewers, passed CI checks, and modified one file with three additions and two deletions.
73%
#4205 lint: fix for pyright 1.1.312 snapcraft merged Merged a fix for type errors in account.py triggered by Pyright 1.1.312's stricter kwargs validation. The change corrects type annotations, passes CI, and was approved by a reviewer.
72%
#441 lint: temporary workaround for pyxdg pyright issues craft-parts closed Incorporated into PR #440 instead of merging directly. The temporary pyright workaround for pyxdg was resolved through that subsequent pull request.
72%
#1525 build: enable pyright charmcraft merged Merged changes enabling pyright type checking. Configured a gradual rollout by downgrading type errors to warnings. Approved by two reviewers, the update modifies 12 files with a +60/-31 line diff.
72%